Skip to content

Latest NumpyToTensorView<T> function requires complex conversion for complex types #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cliffburdick merged 1 commit into from
Jun 7, 2023
Merged

Latest NumpyToTensorView<T> function requires complex conversion for complex types #431

cliffburdick merged 1 commit into from
Jun 7, 2023

Conversation

@nvjonwong
Copy link
Contributor

@nvjonwong nvjonwong commented Jun 7, 2023

Fixes issue where complex types could not be used with NumpyToTensorView because conversion is required to go from cuda::std::complex<T> to/from std::complex<T>.

  • Added unit tests to verify that NumpyToTensorView and TensorViewToNumpy work with complex types.

@nvjonwong nvjonwong requested a review from cliffburdick June 7, 2023 07:22
@nvjonwong nvjonwong self-assigned this Jun 7, 2023
@cliffburdick
Copy link
Collaborator

cliffburdick commented Jun 7, 2023

/blossom-ci

@cliffburdick cliffburdick merged commit 28b9790 into main Jun 7, 2023
@cliffburdick cliffburdick deleted the nvjonwong/fix_numpy_to_tensorview_complex branch June 7, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cliffburdick cliffburdick cliffburdick approved these changes

Assignees

@nvjonwong nvjonwong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nvjonwong @cliffburdick