matmul: support real/complex tensors #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
commented
Jan 24, 2023
Contributor
Author
Collaborator
|
Thanks @kshitij12345 for doing all the work! It looks good, but I left a few comments to help clarify things for me. |
Contributor
Author
|
@cliffburdick Thanks for the review. Will most likely address it by or before this weekend :) |
Collaborator
Thanks! |
Contributor
Author
|
Have updated for the PR based on all the comments barring one. PTAL. Thank you! |
cliffburdick
approved these changes
Jan 26, 2023
Contributor
Author
|
Gentle ping :) |
Collaborator
hi @kshitij12345 , I will test this out first thing tomorrow and merge if all is well |
Contributor
Author
|
Sure. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #353