Add profiling unit tests and fix timer safety #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive unit tests for CUDA executor profiling functionality - Test basic timer operations (start/stop/get_time_ms) - Test behavior when profiling is disabled - Test multiple timer cycles - Test with complex operations and multiple streams - Test profiling overhead - Test with default stream - Fix safety issue in start_timer() and stop_timer() - Add profiling_ checks to prevent crashes when profiling is disabled - Functions are now no-ops when profiling is not enabled - Makes API more robust and user-friendly - Update CMakeLists.txt to include new ProfilingTests.cu The profiling API now gracefully handles all states and provides better safety guarantees. Users can call timer functions without worrying about the profiling state, and only get_time_ms() will throw an exception when profiling is disabled (as intended). Fixes: Segmentation fault when calling timer functions with profiling disabled Tests: Added 8 new test cases covering all profiling functionality
Collaborator
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive unit tests for CUDA executor profiling functionality
Fix safety issue in start_timer() and stop_timer()
Update CMakeLists.txt to include new ProfilingTests.cu
The profiling API now gracefully handles all states and provides better safety guarantees. Users can call timer functions without worrying about the profiling state, and only get_time_ms() will throw an exception when profiling is disabled (as intended).
Fixes: Segmentation fault when calling timer functions with profiling disabled
Tests: Added 8 new test cases covering all profiling functionality