Refactor Storage system to use duck-typed allocators #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace template-based Storage with unified Storage<T> class - Remove inheritance requirement from pmr_allocator_interface - Implement pure duck typing - users just need allocate()/deallocate() methods - Add SFINAE detection for both allocator objects and pointers - Support owning/non-owning constructors with optional custom allocators - Eliminate dynamic allocation overhead for common allocator cases - Maintain backward compatibility with legacy sparse tensor types - Add comprehensive unit tests for duck-typed allocator system - Organize tests in new test/00_misc/ directory following MatX conventions This provides maximum flexibility while removing inheritance requirements and virtual function overhead. Users can now implement any allocator without inheriting from base classes - if it has allocate() and deallocate() methods, it works automatically via SFINAE detection.
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
/build |
Collaborator
Author
|
Passing CI but issue with the coverage uploading at the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides maximum flexibility while removing inheritance requirements and virtual function overhead. Users can now implement any allocator without inheriting from base classes - if it has allocate() and deallocate() methods, it works automatically via SFINAE detection.
Closes #1043 #48