-
Notifications
You must be signed in to change notification settings - Fork 109
Remove runtime checks on memory spaces #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aartbik
commented
Jul 25, 2025
(1) allow a mix of memory spaces inside the sparse tensor;
ultimately, only the visibility matters, not the exact consistency
(2) remove the runtime check on offset = {-1,0,+1} for now;
I see no other solution than copying this to host or having
some kernel check on device, which all seems too costly;
given the very limited usage of UST, we just assume the solve
is only called on tridiag with these offsets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes runtime validation checks for memory spaces and diagonal offsets in sparse tensor operations to improve performance and allow more flexible memory space configurations.
- Removes memory space consistency checks between sparse tensor components (values, coordinates, positions)
- Replaces specific diagonal offset validation with a simpler count-only check
- Adds documentation comments explaining the tridiagonal assumption
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
include/matx/transforms/solve/solve_cusparse.h |
Simplifies diagonal offset validation by removing specific value checks and keeping only count validation |
include/matx/operators/solve.h |
Adds documentation comment about tridiagonal storage assumption |
include/matx/core/sparse_tensor.h |
Removes memory space consistency checks between sparse tensor components |
|
/build |
|
Unrelated failure? matxException (matxOutOfMemory: ) - /home/jenkins/workspace/unit-tests/include/matx/core/allocator.h: |
|
/build |
1 similar comment
|
/build |