use batched sparse solve for interp #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aartbik
reviewed
Jul 28, 2025
simonbyrne
force-pushed
the
sbyrne/interp-sparse
branch
from
2b1b6ef to
02f6ed1
Compare
simonbyrne
commented
Jul 28, 2025
simonbyrne
force-pushed
the
sbyrne/interp-sparse
branch
from
02f6ed1 to
554d702
Compare
Collaborator
|
Very nice! Thank you so much for doing this refactoring towards using the UST everywhere! Do you have a performance benchmark to ensure performance is as expected? [I see no reason why it would change, but of course we should pedantically check] |
Collaborator
|
/build |
simonbyrne
force-pushed
the
sbyrne/interp-sparse
branch
from
554d702 to
93a3b4b
Compare
Collaborator
Author
|
@cliffburdick I've rebased on #1017, it should work now. |
Collaborator
|
/build |
cliffburdick
approved these changes
Jul 29, 2025
cliffburdick
approved these changes
Jul 29, 2025
cliffburdick
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.