Skip to content

Fix ARM relocation trucation build errors #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cliffburdick merged 2 commits into from
Jul 15, 2025
Merged

Fix ARM relocation trucation build errors #1008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935e296
Initial fix for ARM relocation trucation build errors
dylan-eustice Jul 7, 2025
60417d1
Move PIC flags into GetGTest.cmake
dylan-eustice Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cmake/GetGTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,21 @@ function(find_and_configure_gtest VERSION)
return()
endif()

# Set GoogleTest-specific options
set(GTEST_OPTIONS "INSTALL_GTEST ON")
if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64")
# Force PIC for GoogleTest on ARM64 to avoid relocation issues
list(APPEND GTEST_OPTIONS "CMAKE_POSITION_INDEPENDENT_CODE ON")
message(STATUS "Enabling PIC for GoogleTest on ARM64")
endif()

# Find or install GoogleTest
CPMFindPackage(NAME GTest
VERSION ${VERSION}
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG v${VERSION}
GIT_SHALLOW TRUE
OPTIONS "INSTALL_GTEST ON"
OPTIONS ${GTEST_OPTIONS}
# googletest >= 1.10.0 provides a cmake config file -- use it if it exists
FIND_PACKAGE_ARGUMENTS "CONFIG")
# Add GTest aliases if they don't already exist.
Expand Down