Skip to content

Fix host compiler errors when using -Wall -Werror #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmartin-gh merged 3 commits into from
Jul 9, 2025
Merged

Fix host compiler errors when using -Wall -Werror #1006

tmartin-gh merged 3 commits into from
Jul 9, 2025

Conversation

@tmartin-gh
Copy link
Collaborator

@tmartin-gh tmartin-gh commented Jul 8, 2025 •
edited
Loading

These compiler errors exhibit with matx header included in .cpp file when compiled with -Wall -Werror

  • error: typedef 'using NTypeS = typename matx::inner_op_type_t::type' locally defined but not used
  • error: ignoring '#pragma unroll ' [-Werror=unknown-pragmas]
  • error: unused variable 'ret' [-Werror=unused-variable]

This MR provides the fix by eliminating the unused type and replacing #pragma unroll with a MATX_LOOP_UNROLL macro.

@tmartin-gh
Fix compiler error: typedef 'using NTypeS = typename matx::inner_op_t…
9fd80eb 
…ype_t<typename ATensor::value_type>::type' locally defined but not used
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 8, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tmartin-gh tmartin-gh requested a review from cliffburdick July 8, 2025 18:03
@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh tmartin-gh changed the title Fix compiler error typename locally defined but not used Fix host compiler errors when using -Wall -Werror Jul 8, 2025
@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh tmartin-gh force-pushed the unusedlocaltypedef branch from 7d149bd to 1325441 Compare July 8, 2025 19:26
@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh tmartin-gh force-pushed the unusedlocaltypedef branch from 1325441 to 85934f8 Compare July 8, 2025 19:35
@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh tmartin-gh force-pushed the unusedlocaltypedef branch from 85934f8 to e4ecbaf Compare July 8, 2025 20:47
@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jul 8, 2025

/build

@tmartin-gh tmartin-gh merged commit 09505b5 into NVIDIA:main Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luitjens luitjens luitjens approved these changes

@cliffburdick cliffburdick Awaiting requested review from cliffburdick

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmartin-gh @luitjens