test for batched tri-diag direct solver #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new unit test for the batched uniform DIA direct solver in the DiaSolveSparseTestsAll suite, verifying that solve correctly handles multiple small tridiagonal systems in a batched form.
- Introduce
SolveBatchedUniformDIAItyped test to cover uniform-batched DIA solves - Set up diagonal data (
D), offsets (O), and RHS/expected tensors (X,E) for two 4×4 systems - Invoke
solve(A, X)and assert near-equality against expected results for both real and complex types
Comments suppressed due to low confidence (2)
test/00_sparse/Dia.cu:241
- [nitpick] The ASCII-art comments describing matrix layout (lines 241–245) are hard to follow and partially redundant. Consider simplifying or aligning the diagram with the data ordering in
D.
// batch0 batch1 batch0 batch1
test/00_sparse/Dia.cu:279
- [nitpick] The comment on line 280 labels 'RHS' but then repeats matrix values; update it to clearly show that it's the RHS (A * E = X) or adjust the diagram to match what's being described.
// RHS.
Collaborator
|
/build |
3 similar comments
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
|
/build |
Collaborator
Author
|
Merged with #999, this is now good to go! |
Collaborator
|
/build |
cliffburdick
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is waiting for #999