[WIP] filter job by topology - step 1 #334
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidLif
force-pushed
the
DavidL/29136/topologyFiltering
branch
from
749d1cf to
12aafda
Compare
itsomri
reviewed
Jul 27, 2025
itsomri
reviewed
Jul 27, 2025
itsomri
reviewed
Jul 27, 2025
pkg/scheduler/plugins/topology/topology_plugin_job_filtering.go
Outdated
Show resolved
Hide resolved
itsomri
reviewed
Jul 27, 2025
Comment on lines
52
to
66
| t.calcTreeAlocationData(job, topologyTree) | ||
|
|
||
| // Get best domains for the job | ||
| jobAllocateableDomain, err := t.getBestjobAllocateableDomains(job, topologyTree) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Is there any case where these two are not called together? If not, just call calcTreeAlocationData from inside getBestjobAllocateableDomains
There was a problem hiding this comment.
I think that it makes sense to separate them as 2 different steps in the proccess:
1- Get matching topology
2- See if we have the result in cache
3- Calculate allocation data for the given job on all tree nodes
4- Get the domains which satisfies all the requirments
5- Save to cache
itsomri
reviewed
Jul 27, 2025
pkg/scheduler/plugins/topology/topology_plugin_job_filtering.go
Outdated
Show resolved
Hide resolved
davidLif
force-pushed
the
DavidL/29136/topologyFiltering
branch
2 times, most recently
from
30b5497 to
388fe85
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
enoodle
reviewed
Jul 29, 2025
pkg/scheduler/plugins/topology/topology_plugin_job_filtering.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/topology/topology_plugin_job_filtering.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/topology/topology_plugin_job_filtering.go
Outdated
Show resolved
Hide resolved
Known issue: wrong distance calculation
davidLif
force-pushed
the
DavidL/29136/topologyFiltering
branch
from
ed5440a to
4cd88c1
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base code fro prePredicate with node allocation checks instead of domain sum