-
Notifications
You must be signed in to change notification settings - Fork 11
Fail safe makedirs #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A more pythonic way to create directories if doens't exists.
|
Hey @imneonizer, thanks for putting this together! This looks great and I'd be happy to merge it, but do you mind putting a "Signed-Off-By: Name email" at the end of your commit? Something like: This just helps us ensure all contributors acknowledge the Contributors License Agreement for the repo. Once that's done and the tests pass, I'd be happy to merge! |
|
@roclark Thank you for the info, I have updated the commit message, hope this works. |
|
Thanks for following up @imneonizer! I believe I may have misspoke earlier - I meant to say the commit message I used as an example above should be embedded in your actual commit as opposed to the pull request on GitHub. That way, your Also, it appears the CI tests are currently failing with an extra whitespace. I can point this out in the code if that helps. Preferably, the updated commit message and the removal of the extra whitespace will be done in the same, single commit. Thanks again for taking the time for this! Please let me know if there are any further questions. |
Signed-Off-By: Nitin Rai [email protected]
|
@roclark |
|
Hey @imneonizer, sorry for not getting to this yesterday! Thanks for cleaning things up here - this looks good to me and I am happy to merge it! I will do a squash commit to combine your two commits into one and include it with the main branch. Thanks for creating this and I'm happy to play my little part in your first PR with NVIDIA! 😃 I welcome any future PRs you may have as well! |
A more pythonic way to create directories if doesn't exists.