Skip to content

remove hyphens and fix year copyright coverage#453

Merged
shubhadeepd merged 1 commit intoNVIDIA-AI-Blueprints:release-v2.4.0from
kheiss-uwzoo:kheiss/remove-hyphens
Apr 3, 2026
Merged

remove hyphens and fix year copyright coverage#453
shubhadeepd merged 1 commit intoNVIDIA-AI-Blueprints:release-v2.4.0from
kheiss-uwzoo:kheiss/remove-hyphens

Conversation

@kheiss-uwzoo
Copy link
Copy Markdown
Collaborator

@kheiss-uwzoo kheiss-uwzoo commented Apr 1, 2026

Description

remove hyphens and fix year copyright coverage.

Copy link
Copy Markdown

@JiwaniZakir JiwaniZakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The %Y format specifier in both the file header comment and the copyright variable in docs/conf.py will not be automatically substituted — Sphinx does not process strftime-style tokens in the copyright string. As a result, the built docs will literally display "2025-%Y, NVIDIA Corporation" rather than a dynamic year range. If the intent is to show a year range through the current year, it needs to be computed explicitly, e.g., copyright = f"2025-{datetime.datetime.now().year}, NVIDIA Corporation" with a corresponding import datetime at the top of the file.

The rename of project from " NVIDIA-RAG-blueprint" to " NVIDIA RAG blueprint" is reasonable for readability, but note the leading space in that string has been present since before this PR and is likely unintentional — worth cleaning up in the same pass. Also, the PR description says "remove hyphens," but the %Y addition is a separate, unrelated change that significantly affects the copyright output and should be called out explicitly in the PR description.

@kheiss-uwzoo
Copy link
Copy Markdown
Collaborator Author

@kheiss-uwzoo kheiss-uwzoo added the documentation Improvements or additions to documentation label Apr 1, 2026
@kheiss-uwzoo kheiss-uwzoo changed the title remove hyphens remove hyphens and fix year copyright coverage Apr 1, 2026
@shubhadeepd shubhadeepd merged commit a1ca1bb into NVIDIA-AI-Blueprints:release-v2.4.0 Apr 3, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants