Admin UI Upgrades #429
Merged
Admin UI Upgrades #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ember-cli-format-number wasn't compatible with newer versions, implement our own helper using numeral.js directly.
- Get rid of global usage, and import all libraries. - Various fixes for the query builder in bootstrap 4. - Switch to tippy.js for tooltips for easier module imports.
Upgrade to Bootstrap 4.2 beta from git, to get more usable custom radio/checkbox styles with better contrast and borders.
Ember 3 is no longer compatible with PhantomJS, so begin shifting the test suite to headless Chrome, which should be better anyway. This requires some changes in some functionality that isn't possible under Selenium, like setting cookies and setting the language headers.
Since CircleCI's images don't run as root by default, make some adjustments.
Looks like these environment variables have to be set in the web interface to work in this substitution context.
CodeMirror seems to behave a bit better in our integration tests, and since our usage is simple, we'll go ahead and swap the editors.
Our CSS approach to disable animations doesn't seem sufficient for some reason with headless chrome. So go ahead and disable the fades completely, which seems to fix this. Others reporting the same behavior: teamcapybara/capybara#1890 (comment)
Just setting to an empty string wasn't triggering change events, so computed ember fields weren't properly updating.
The data-toggle option was triggering Bootstrap's default dropdown behavior, which isn't actually what we want for the datepicker dropdown (since that library handles dropdowns itself).
With the switch to selenium tests, this was throwing an error.
Bootstrap 4 got rid of the loading state functionality, so implement this toggling behavior on our own to disable the button and change the text when submitting. Add tests.
unloadAll seems to be behaving differently after the Ember upgrade, which was leading to problems in development mode editing the same record repeatedly (but strangely not in production builds). Fix this by wrapping the unloadAll in the run loop. Add better test coverage of the various things this UncachedModel mixin handles.
This didn't always seem to work, and now that Ember has moved the temp directory storage to the system-wide /tmp, this isn't needed as much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades various dependencies within the admin UI to make maintenance easier.