[GCAFS] Move ROTDIR into JJOB & remove obsolete def variables#4724
[GCAFS] Move ROTDIR into JJOB & remove obsolete def variables#4724TravisElless-NOAA wants to merge 6 commits intoNOAA-EMC:dev/gcafs.v1from
Conversation
TravisElless-NOAA
requested review from
CarlosMDiaz-NCO,
CoryMartin-NOAA,
bbakernoaa and
lipan-NOAA
TravisElless-NOAA
requested review from
DavidHuber-NOAA,
aerorahul and
lgannoaa
as code owners
TravisElless-NOAA
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
This is a literal string. To run as a command, use $(..) instead of '..' . SC2041
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGLOBAL_STAGE_IC
Line 21 in 06ac355
🚫 [shellcheck] reported by reviewdog 🐶
You need a space after the '{'. SC1054
This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
🚫 [shellcheck] reported by reviewdog 🐶
You need a space after the '{'. SC1054
This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
🚫 [shellcheck] reported by reviewdog 🐶
Expected a '}'. If you have one, try a ; or \n in front of it. SC1056
🚫 [shellcheck] reported by reviewdog 🐶
Missing '}'. Fix any mentioned problems and try again. SC1072
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGLOBAL_CLEANUP
Line 14 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGDAS_FIT2OBS
Line 28 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGEFS_WAVE_STAT
Line 20 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGDAS_ENKF_POST
Line 21 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGLOBAL_FETCH
Line 21 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
global-workflow/dev/jobs/JGLOBAL_FORECAST
Line 59 in 06ac355
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
Declare and assign separately to avoid masking return values. SC2155
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Looks good, thanks @TravisElless-NOAA !
dev/jobs/JGCDAS_PREPARE_OBS
Outdated
| # Setup Python path for pygfs | ||
| PYTHONPATH="${HOMEglobal}/ush/python${PYTHONPATH:+:${PYTHONPATH}}" | ||
| export PYTHONPATH | ||
| export ROTDIR=$(compath.py "${envir}/${NET}/${gcafs_ver}") |
There was a problem hiding this comment.
To get rid of the pesky shfmt errors, this should be on two lines, just like the PYTHONPATH declaration above:
| export ROTDIR=$(compath.py "${envir}/${NET}/${gcafs_ver}") | |
| ROTDIR=$(compath.py "${envir}/${NET}/${gcafs_ver}") | |
| export ROTDIR |
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
🚫 [shellcheck] reported by reviewdog 🐶
You need a space after the '{'. SC1054
This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
🚫 [shellcheck] reported by reviewdog 🐶
Expected a '}'. If you have one, try a ; or \n in front of it. SC1056
🚫 [shellcheck] reported by reviewdog 🐶
Missing '}'. Fix any mentioned problems and try again. SC1072
| ROTDIR=$(compath.py "${envir}/${NET}/${gcafs_ver}") | ||
| export ROTDIR | ||
|
|
||
| {% if RUN == "gcdas" %} |
| ROTDIR=$(compath.py "${envir}/${NET}/${gcafs_ver}") | ||
| export ROTDIR | ||
|
|
||
| {% if RUN == "gcdas" %} |
6 participants
Description
This PR is a continuation from #4701. Previously ROTDIR was designed to use compath.py in config.base. This PR moves this variable out of config.base and explicitly sets ROTDIR in each jjob.
Additionally, I have removed two variables from the gcafs_v1.def ecf script that should no longer need to be defined.
Resolves #4689
Type of change
Change characteristics
How has this been tested?
GCDAS 00z ecflow cycle
Checklist