Skip to content

De-template COM in v17#4707

Open
DavidHuber-NOAA wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:feature/detemplate_com_v17
Open

De-template COM in v17#4707
DavidHuber-NOAA wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:feature/detemplate_com_v17

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Mar 25, 2026 •
edited
Loading

Description

This makes COM declarations explicit in GFS v17 and removes the use of declare_from_tmpl.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Full tests running on C6 and WCOSS2.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review April 1, 2026 16:56
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

DavidHuber-NOAA commented Apr 1, 2026

All tests ran successfully on C6. Opening for review.

JessicaMeixner-NOAA
JessicaMeixner-NOAA approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and what was put in develop before.

Since some gempak jobs changed, should we run a quick test on wcoss2 as well?

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

DavidHuber-NOAA commented Apr 1, 2026

Looks good to me and what was put in develop before.

Since some gempak jobs changed, should we run a quick test on wcoss2 as well?

Yes, I will run on WCOSS2 as well.

EdwardSafford-NOAA
EdwardSafford-NOAA approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monitor changes look good.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress label Apr 1, 2026
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

DavidHuber-NOAA commented Apr 2, 2026 •
edited
Loading

All tests passed on WCOSS2.

Thu Apr 2 14:19:56 UTC 2026
******** C48_ATM_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202103231200 Done Apr 01 2026 18:15:45 Apr 01 2026 19:20:55

******** C48mx500_3DVarAOWCDA_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202103241800 Done Apr 01 2026 18:15:41 Apr 01 2026 18:35:35
202103250000 Done Apr 01 2026 18:15:41 Apr 01 2026 20:10:49

******** C48mx500_hybAOWCDA_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202103241800 Done Apr 01 2026 18:15:17 Apr 01 2026 18:30:15
202103250000 Done Apr 01 2026 18:15:17 Apr 01 2026 19:40:16

******** C48_S2SW_extended_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202103231200 Done Apr 01 2026 18:15:21 Apr 01 2026 20:50:18
202103231800 Done Apr 01 2026 18:15:21 Apr 01 2026 20:30:18

******** C96_atm3DVar_extended_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202112201800 Done Apr 01 2026 18:15:31 Apr 01 2026 18:35:19
202112210000 Done Apr 01 2026 18:15:31 Apr 01 2026 21:00:40
202112210600 Done Apr 01 2026 18:15:31 Apr 01 2026 21:55:44
202112211200 Done Apr 01 2026 18:40:31 Apr 01 2026 22:40:47
202112211800 Done Apr 01 2026 21:05:35 Apr 01 2026 23:45:39

******** C96C48_hybatmDA_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202112201800 Done Apr 01 2026 18:15:38 Apr 01 2026 18:35:37
202112210000 Done Apr 01 2026 18:15:38 Apr 01 2026 20:35:38
202112210600 Done Apr 01 2026 18:15:38 Apr 01 2026 20:40:53

******** C96C48_hybatmsnowDA_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202112201200 Done Apr 01 2026 18:15:46 Apr 01 2026 18:35:11
202112201800 Done Apr 01 2026 18:15:46 Apr 01 2026 20:30:46
202112210000 Done Apr 01 2026 18:15:46 Apr 01 2026 20:35:31

******** C96C48_hybatmsoilDA_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202205150600 Done Apr 01 2026 18:15:29 Apr 01 2026 18:35:15
202205151200 Done Apr 01 2026 18:15:29 Apr 01 2026 20:30:57
202205151800 Done Apr 01 2026 18:15:29 Apr 01 2026 20:40:16

******** C96C48mx500_S2SW_cyc_gfs_detemplate_v17 ********
CYCLE STATE ACTIVATED DEACTIVATED
202112201200 Done Apr 01 2026 18:15:25 Apr 01 2026 18:35:12
202112201800 Done Apr 01 2026 18:15:25 Apr 01 2026 21:10:38
202112210000 Done Apr 01 2026 18:15:25 Apr 01 2026 21:30:41
202112211800 Done Apr 01 2026 18:40:35 Apr 01 2026 21:40:42

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Apr 2, 2026
AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems with marine code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@bbakernoaa bbakernoaa bbakernoaa approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@EdwardSafford-NOAA EdwardSafford-NOAA EdwardSafford-NOAA approved these changes

@ClaraDraper-NOAA ClaraDraper-NOAA Awaiting requested review from ClaraDraper-NOAA ClaraDraper-NOAA is a code owner

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA RussTreadon-NOAA is a code owner

@sbanihash sbanihash Awaiting requested review from sbanihash sbanihash is a code owner

@ChristopherHill-NOAA ChristopherHill-NOAA Awaiting requested review from ChristopherHill-NOAA ChristopherHill-NOAA is a code owner

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA CatherineThomas-NOAA is a code owner

@jiaruidong2017 jiaruidong2017 Awaiting requested review from jiaruidong2017 jiaruidong2017 is a code owner

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres guillaumevernieres is a code owner

@JesseMeng-NOAA JesseMeng-NOAA Awaiting requested review from JesseMeng-NOAA JesseMeng-NOAA is a code owner

@EricSinsky-NOAA EricSinsky-NOAA Awaiting requested review from EricSinsky-NOAA EricSinsky-NOAA is a code owner

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA DavidNew-NOAA is a code owner

@WenMeng-NOAA WenMeng-NOAA Awaiting requested review from WenMeng-NOAA WenMeng-NOAA is a code owner

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA BrianCurtis-NOAA is a code owner

@BoCui-NOAA BoCui-NOAA Awaiting requested review from BoCui-NOAA BoCui-NOAA is a code owner

@HananehJafary-NOAA HananehJafary-NOAA Awaiting requested review from HananehJafary-NOAA HananehJafary-NOAA is a code owner

@jack-woollen jack-woollen Awaiting requested review from jack-woollen jack-woollen is a code owner

@TravisElless-NOAA TravisElless-NOAA Awaiting requested review from TravisElless-NOAA TravisElless-NOAA is a code owner

Assignees

No one assigned

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DavidHuber-NOAA @CoryMartin-NOAA @bbakernoaa @JessicaMeixner-NOAA @AndrewEichmann-NOAA @EdwardSafford-NOAA