Skip to content

[GFS v17] Introduction of ecFlow support for GFS v17#4667

Draft
DavidHuber-NOAA wants to merge 3 commits intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/ecf_v17
Draft

[GFS v17] Introduction of ecFlow support for GFS v17#4667
DavidHuber-NOAA wants to merge 3 commits intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/ecf_v17

Conversation

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Mar 17, 2026

Description

When running ecflow, loading prod_util causes issues with the suite (it should only be loaded in the ecf scripts). Similarly, modules should not be reset when running ecflow cases as this will cause prod_util to be unloaded.

Refs #4599

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • GDASApp

How has this been tested?

@lgannoaa is testing this change presently.
I also verified that setting ECF_JOB and then loading the modules prevented prod_util from loading.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@DavidHuber-NOAA DavidHuber-NOAA added the needs submodule update Requires submodule PRs to be merged label Mar 17, 2026
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

This PR requires a GDASApp update, hence the needs submodule update label. Once the GDASApp PR is open, I will open this PR for review.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

@lgannoaa did this work successfully for you?

DavidHuber-NOAA and others added 2 commits March 24, 2026 19:42
)

* Design the ecflow workflow for GFS v17 implementation realtime parallel.
This version is intended for GFS EE2 review by NCO SPA team.
The ecflow workflow is enabled to run the j-job.
setup_ecf_links.sh must be run during the linking stage, after the executable is built, to enable the full ecflow suite.

Lin Gan 04/01/02026

* Update jobs/JGFS_ATMOS_FBWIND-0317-1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
declare -rx COMOUT="${ROTDIR}/${RUN}.${PDY}/${cyc}/products/atmos/wmo"

#### workaround for path assignment bug in declare_from_tmpl
COMOUT=$(echo "$COMOUT" | tr -s '/')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
COMOUT=$(echo "$COMOUT" | tr -s '/')
COMOUT=$(echo "${COMOUT}" | tr -s '/')

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

@lgannoaa thanks for the work to get ecflow to work. I do have some suggestions on how you have set up the jobs and scripts directories and I think @CoryMartin-NOAA would be a great resource for this, as he is handling this for GCAFS. Rather than moving the jobs and scripts to jobs/ and scripts, GCAFS installs the package. I think this would be a much more sustainable path forward for the GFS.

Cory, maybe you, Lin, myself, and @TravisElless-NOAA can tag-up to work through how this is done sometime next week?

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

Next week I'm pretty booked with a code sprint and visitors but I can try to find some time.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor Author

Thanks @CoryMartin-NOAA. I'll find something on our calendars.

@DavidHuber-NOAA DavidHuber-NOAA changed the title Do not module reset or load prod_util when running ecflow [GFS v17] Introduction of ecFlow support for GFS v17 Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs submodule update Requires submodule PRs to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants