Patch: Enable custom array design layout generation for WOMBAT compatibility#707
Open
RHammond2 wants to merge 4 commits intoNLRWindSystems:masterfrom
Open
Patch: Enable custom array design layout generation for WOMBAT compatibility#707RHammond2 wants to merge 4 commits intoNLRWindSystems:masterfrom
RHammond2 wants to merge 4 commits intoNLRWindSystems:masterfrom
Conversation
Contributor
|
I just built this out and ran the unit tests in Ard; the custom array layout issues described in #703 are resolved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR allows for the use of ORBIT's
CustomArraySystemDesigntooling when capturing the WOMBAT-compatible layout data by using the latest ORBIT patch and adding better control flow to the ORBITcompute()method. I have also added a missing__version__attribute that should be made available for Python libraries.Closes #703
Type of change
Testing
N/A
Checklist