changes by review

Author: tbauriedel

.gitignore

@@ -1,4 +1,4 @@
 .cache
 *.swp
 __pycache__*
-.vscode
+.vscode

docs/module-elasticsearch_role.md

@@ -23,7 +23,7 @@ Module arguments
 * *host*: API endpoint (**Required**)
 * *auth_user*: User to authenticate on the Elasticsearch API (**Required**)
 * *auth_pass*: Password for the given user (**Required**)
-* *verify_certs*: Verify certificates (Default: True)
+* *verify_certs*: Verify certificates (Default: `true`)
 * *ca_certs*: Verify HTTPS connection by using ca certificate. Path to ca needs to be given
 
 Example usage

docs/module-elasticsearch_user.md

@@ -24,7 +24,7 @@ Module arguments
 * *host*: API endpoint (**Required**)
 * *auth_user*: User to authenticate on the Elasticsearch API (**Required**)
 * *auth_pass*: Password for the given user (**Required**)
-* *verify_certs*: Verify certificates (Default: True)
+* *verify_certs*: Verify certificates (Default: `true`)
 * *ca_certs*: Verify HTTPS connection by using ca certificate. Path to ca needs to be given
 
 Example usage

molecule/elasticsearch_test_modules/converge.yml

@@ -6,11 +6,11 @@
     - netways.elasticstack
   hosts: all
   vars:
-    #elasticsearch_security: true # needed for tests of > 7 releases
     elasticstack_full_stack: false
     elasticsearch_jna_workaround: true
     elasticsearch_disable_systemcallfilterchecks: true
-    elasticstack_release: "{{ lookup('env', 'ELASTIC_RELEASE') | int}}"
+    #elasticstack_release: "{{ lookup('env', 'ELASTIC_RELEASE') | int}}"
+    elasticstack_release: 8
     elasticsearch_heap: "1"
     elasticstack_no_log: false
   tasks:

molecule/elasticsearch_test_modules/molecule.yml

@@ -18,5 +18,7 @@ platforms:
     pre_build_image: true
 provisioner:
   name: ansible
+  env:
+    ANSIBLE_VERBOSITY: 3
 verifier:
   name: ansible

molecule/elasticsearch_test_modules/prepare.yml

@@ -20,4 +20,3 @@
         name: "{{ item }}"
       loop:
         - elasticsearch
-        - certifi

plugins/module_utils/api.py

@@ -12,4 +12,4 @@ def new_client_basic_auth(host, auth_user, auth_pass, ca_certs, verify_certs) ->
         ctx = ssl.create_default_context(cafile=ca_certs)
         ctx.check_hostname = False
         ctx.verify_mode = False
-        return Elasticsearch(hosts=[host], basic_auth=(auth_user, auth_pass), ssl_context=ctx, verify_certs=verify_certs)
+        return Elasticsearch(hosts=[host], basic_auth=(auth_user, auth_pass), ssl_context=ctx, verify_certs=verify_certs)

plugins/modules/elasticsearch_role.py

@@ -54,7 +54,7 @@ def run_module():
             # Auth args
             host=dict(type=str, required=True),
             auth_user=dict(type=str, required=True),
-            auth_pass=dict(type=str, required=True),
+            auth_pass=dict(type=str, required=True, no_log=True),
             ca_certs=dict(type=str, required=False),
             verify_certs=dict(type=bool, required=False, default=True)
         )

plugins/modules/elasticsearch_user.py

@@ -40,7 +40,7 @@ def run_module():
             # User args
             name=dict(type=str, required=True),
             fullname=dict(type=str, required=False),
-            password=dict(type=str, required=True),
+            password=dict(type=str, required=True, no_log=True),
             email=dict(type=str, required=False),
             roles=dict(type=list, required=True),
             enabled=dict(type=bool, required=False, default=True),
@@ -49,7 +49,7 @@ def run_module():
             # Auth args
             host=dict(type=str, required=True),
             auth_user=dict(type=str, required=True),
-            auth_pass=dict(type=str, required=True),
+            auth_pass=dict(type=str, required=True, no_log=True),
             ca_certs=dict(type=str, required=False),
             verify_certs=dict(type=bool, required=False, default=True)
         )