un-nest conditions

Author: tbauriedel

plugins/module_utils/elasticsearch_role.py

@@ -60,10 +60,12 @@ def handle_present(self):
             self.result['msg'] = self.role_name + " has been created"
             return
 
-        if pre_role != None:
-            if pre_role.raw != self.get().raw:
-                self.result['changed'] = True
-                self.result['msg'] = self.role_name + " has been updated"
+        if pre_role == None:
+            return
+
+        if pre_role.raw != self.get().raw:
+            self.result['changed'] = True
+            self.result['msg'] = self.role_name + " has been updated"
 
         return
 

plugins/module_utils/elasticsearch_user.py

@@ -62,7 +62,10 @@ def handle_present(self):
             self.result['msg'] = self.user_name + " has been created"
             return
 
-        if pre_user != None and pre_user.raw != self.get().raw:
+        if pre_user == None:
+            return
+
+        if pre_user.raw != self.get().raw:
             self.result['changed'] = True
             self.result['msg'] = self.user_name + " has beed updated"