Skip to content

Fix bug in cf.aggregate that sometimes put a null transpose operation into the Dask grpah when one was not needed #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix bug in cf.aggregate that sometimes put a null transpose operation into the Dask grpah when one was not needed #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ version NEXT
* Fix bug in `cf.read` when reading UM files that caused LBPROC value
131072 (Mean over an ensemble of parallel runs) to be ignored
(https://github.com/NCAS-CMS/cf-python/issues/737)
* Fix bug in `cf.aggregate` that sometimes put a null transpose
operation into the Dask grpah when one was not needed
(https://github.com/NCAS-CMS/cf-python/issues/754)

----

Expand Down
2 changes: 1 addition & 1 deletion cf/aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4817,7 +4817,7 @@ def _aggregate_2_fields(

# Ensure that the axis orders are the same in both fields
transpose_axes1 = [dim0_name_map[axis0] for axis0 in data_axes0]
if transpose_axes1 != data_axes1:
if transpose_axes1 != list(data_axes1):
parent1.transpose(transpose_axes1, inplace=True)

construct_type = parent0.construct_type
Expand Down