Skip to content

New remove_vertical_crs keyword to cf.Field.collapse #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

New remove_vertical_crs keyword to cf.Field.collapse #600

merged 3 commits into from
Mar 1, 2023

Conversation

davidhassell
Copy link
Collaborator

Fixes #599

@davidhassell davidhassell added this to the Next release milestone Feb 23, 2023
sadielbartholomew
sadielbartholomew approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue at hand with a nice implementation and adds sufficient testing to confirm that it does. I've raised one minor comment, but otherwise this is all good.

@davidhassell @sadielbartholomew
Typo
3b84758 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit f6798df into NCAS-CMS:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.1
Development

Successfully merging this pull request may close these issues.

cf.Field.collapse should delete a vertical CRS that spans a collapse axis
2 participants
@davidhassell @sadielbartholomew