Skip to content

Conversation

davidhassell
Copy link
Collaborator

Minor bug fix for the new element caching for Data.__str__.

@davidhassell davidhassell added low priority dask Relating to the use of Dask labels Nov 22, 2022
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A justified change, with apologies for missing the subtlety in question during code review for #494. All good, please merge!

To note, I'm noticing the occasional segmentation fault on the test_read_write test (it's hard to estimate at what frequency as, all in the same environment e.g. desktop or laptop, they tend to happen often over short periods and then not at all for some reason). I did check by running it on the lama-to-dask branch too that it isn't something related to this change, and indeed I see the seg faults intermittently on that too. (I'm not sure if I was seeing those on there recently so far as I remember, but don't think I was, so perhaps a recent change has led to this? Are you seeing seg faults at all?)

@davidhassell davidhassell changed the title dask: Fix for cached str` data elements dask: Fix for cached str-type data elements Nov 23, 2022
@davidhassell
Copy link
Collaborator Author

Thanks, Sadie.

Are you seeing seg faults at all?)

One or two in the last month? Sufficiently few that I forgot about them, but I'll keep a tally now ...

@davidhassell davidhassell merged commit d8089d2 into NCAS-CMS:lama-to-dask Nov 23, 2022
@davidhassell davidhassell deleted the dask-uncompress branch November 23, 2022 09:07
@davidhassell davidhassell added this to the 3.14.0 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants