Skip to content

dask: Data.Units #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

dask: Data.Units #405

merged 3 commits into from
May 13, 2022

Conversation

davidhassell
Copy link
Collaborator

Code reorganisation for consistency. Also new unit test.

@davidhassell davidhassell added the dask Relating to the use of Dask label May 12, 2022
@davidhassell davidhassell mentioned this pull request May 12, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. One very minor suggestion raised, but this is all good to merge so please go ahead when ready. Thanks.

@davidhassell davidhassell merged commit 632b396 into NCAS-CMS:lama-to-dask May 13, 2022
@davidhassell davidhassell deleted the dask-Units branch November 15, 2022 09:25
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew