Fix Placemark rotation and tilt#869
Open
EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
Open
Fix Placemark rotation and tilt#869EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
EMaksymenko wants to merge 1 commit intoNASAWorldWind:developfrom
Conversation
1) Change order of unitSquareTransform matrix operations to fix image stretching on rotation and apply correct pivot point. 2) Normalize unitSquareTransform matrix Z-range to prevent texture clipping on tilting.
PJHogan
approved these changes
Mar 27, 2022
PJHogan
approved these changes
Mar 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why Should This Be In Core?
Original code had incorrect placemark orientation processing logic and should be fixed.
Benefits
Now Placemarks are correctly rotated and tilted.
Potential Drawbacks
None
Applicable Issues
WorldWindEarth#63