Remove unnecessary patterns from mythtv/external/.gitignore #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.h and version.h are used filenames in subdirectories of mythtv/external. config.* is only ignored in the mythtv/ directory, not is subdirectories, by mythtv/.gitignore by using `/config.*`, so `!config.*` is unnecessary. version.h is also excluded in libmythbase/.gitignore, which does not apply to files in mythtv/external, but that filename is used in FFmpeg. config.mak is excluded by FFmpeg/ffbuild/.gitignore. config.h is excluded by FFmpeg/.gitignore, but that filename is used in libexiv2. I think it is clearer if the .gitignore rule is where the file is generated. avconfig.h is excluded by FFmpeg/libavutil/.gitignore. FFmpeg/.gitignore ignores *_g. Nothing creates FFmpeg.old. All other rules are already in FFmpeg/.gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.h and version.h are used filenames in subdirectories
of mythtv/external.
config.* is only ignored in the mythtv/ directory, not is
subdirectories, by mythtv/.gitignore by using
/config.*,so
!config.*is unnecessary.version.h is also excluded in libmythbase/.gitignore, which
does not apply to files in mythtv/external, but that filename
is used in FFmpeg.
config.mak is excluded by FFmpeg/ffbuild/.gitignore.
config.h is excluded by FFmpeg/.gitignore, but that filename
is used in libexiv2. I think it is clearer if the .gitignore
rule is where the file is generated.
avconfig.h is excluded by FFmpeg/libavutil/.gitignore.
FFmpeg/.gitignore ignores *_g.
Nothing creates FFmpeg.old.
All other rules are already in FFmpeg/.gitignore.
Checklist