Navbar Adjustments #100
Merged
Navbar Adjustments #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocFX dynamically generates the navbar on the client side through the docfx.js code, it's not something that is statically rendered when the page is built. In order for the Donate button to be placed to the left of the theme switch button like on the main monogame side, the Donate button needs to be injected after the page loads and then after the navbar is dynamically generated.
CartBlanche
added a commit
that referenced
this pull request
Feb 10, 2025
* Fix link in ReadMe. * Add Resources to nav-bar, move Donate to button. * Navbar Adjustments (#100) * Inject donate into navbar DocFX dynamically generates the navbar on the client side through the docfx.js code, it's not something that is statically rendered when the page is built. In order for the Donate button to be placed to the left of the theme switch button like on the main monogame side, the Donate button needs to be injected after the page loads and then after the navbar is dynamically generated. * Fix navbar container width so it matches main website --------- Co-authored-by: Christopher Whitley <[email protected]> Co-authored-by: Simon (Darkside) Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject Donate Into Navbar
DocFX dynamically generates the navbar on the client side through the docfx.js code, it's not something that is statically rendered when the page is built. In order for the Donate button to be placed to the left of the theme switch button like on the main monogame side, the Donate button needs to be injected after the page loads and then after the navbar is dynamically generated.
Fix Navbar Container Width
DocFX uses Bootstrap 3.4.1 while the main monogame website uses Bootstrap 5.3.2. This adjusts the navbar container only to match the
max-widthvalue of the current bootstrap version that is used on the main site so that it appears more centered.