- Fix #152: CSV import should ignore currency symbols.

- Fix #150: unhandled exception
- Fix #149: export of an account fails with error popup
- Fix #147: scrolling during reconcile
- Fix #146: unnecessary error popups doing category change
- Fix #143: Feature - export accounts - currency, start and end
- Feature: add logging to %TEMP%\MyMoney\Logs

Author: clovett

Source/WPF/MoneyPackage/Package.appxmanifest

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap rescap">
-  <Identity Name="43906ChrisLovett.MyMoney.Net" Publisher="CN=Chris Lovett, O=Chris Lovett, S=Washington, C=US" Version="2.1.0.47" />
+  <Identity Name="43906ChrisLovett.MyMoney.Net" Publisher="CN=Chris Lovett, O=Chris Lovett, S=Washington, C=US" Version="2.1.0.48" />
   <Properties>
     <DisplayName>MyMoney.Net</DisplayName>
     <PublisherDisplayName>Chris Lovett</PublisherDisplayName>

Source/WPF/MyMoney/App.xaml

@@ -2,6 +2,7 @@
              xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              Startup="MyApplicationStartup"             
+             DispatcherUnhandledException="OnUnhandledException"
              xmlns:ui="http://schemas.modernwpf.com/2019">
 
 

Source/WPF/MyMoney/App.xaml.cs

@@ -2,7 +2,10 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
+using System.Threading.Tasks;
 using System.Windows;
+using System.Windows.Interop;
+using System.Windows.Threading;
 using System.Xml.Linq;
 using Walkabout.Configuration;
 using Walkabout.Help;
@@ -23,6 +26,10 @@ namespace Walkabout
     /// </summary>
     public partial class App : Application
     {
+        private ILogger rootLog;
+        private Log appLog;
+        private string logsLocation;
+
         private void MyApplicationStartup(object sender, StartupEventArgs e)
         {
             Settings settings = null;
@@ -31,6 +38,16 @@ private void MyApplicationStartup(object sender, StartupEventArgs e)
             using (PerformanceBlock.Create(ComponentId.Money, CategoryId.View, MeasurementId.AppInitialize))
             {
 #endif
+            var path = Path.Combine(Path.GetTempPath(), "MyMoney");
+            var logs = Path.Combine(path, "Logs");
+            Directory.CreateDirectory(logs);
+            this.rootLog = new Log(logs);
+            this.appLog = Log.GetLogger("App");
+            Log.CheckCrashLog(path);
+
+            Debug.WriteLine($"Writing logs to {logs}");
+            appLog.Info("Launching MyMoney.Net");
+
             HelpService.Initialize();
 
             Process currentRunningInstanceOfMyMoney = null;
@@ -61,7 +78,11 @@ private void MyApplicationStartup(object sender, StartupEventArgs e)
             }
 
             // Load the application settings
-            settings = LoadSettings(noSettings);
+            settings = this.LoadSettings(noSettings);
+
+            System.Windows.Forms.Application.SetUnhandledExceptionMode(System.Windows.Forms.UnhandledExceptionMode.CatchException);
+            AppDomain.CurrentDomain.UnhandledException += new UnhandledExceptionEventHandler(this.OnAppDomainUnhandledException);
+            TaskScheduler.UnobservedTaskException += this.TaskScheduler_UnobservedTaskException1;
 
 #if PerformanceBlocks
             }
@@ -72,7 +93,15 @@ private void MyApplicationStartup(object sender, StartupEventArgs e)
             mainWindow.Show();
         }
 
-        public static Settings LoadSettings(bool noSettings)
+        protected override void OnExit(ExitEventArgs e)
+        {
+            this.appLog?.Info($"App terminating with exit code {e.ApplicationExitCode}");
+            this.appLog?.Dispose();
+            this.rootLog?.Dispose();
+            base.OnExit(e);
+        }
+
+        public Settings LoadSettings(bool noSettings)
         {
             // make sure the directory exists.
             ProcessHelper.CreateSettingsDirectory();
@@ -100,7 +129,7 @@ public static Settings LoadSettings(bool noSettings)
             }
             catch (Exception ex)
             {
-                Debug.WriteLine("### Error reading settings: " + ex.Message);
+                this.appLog.Error("### Error reading settings: " + ex.Message);
             }
 
             Settings.TheSettings = s;
@@ -214,12 +243,115 @@ private static Process FindCurrentRunningMoneyApplication()
             return null;
         }
 
+        // stop re-entrancy
+        private bool handlingException;
 
+        private void OnUnhandledException(object sender, System.Windows.Threading.DispatcherUnhandledExceptionEventArgs e)
+        {
+            this.appLog.Error("Unhandled app exception", e.Exception);
+            if (this.handlingException)
+            {
+                e.Handled = false;
+            }
+            else
+            { 
+                this.handlingException = true;
+                UiDispatcher.Invoke(new Action(() =>
+                {
+                    try
+                    {
+                        e.Handled = this.HandleUnhandledException(e.Exception);
+                    }
+                    catch (Exception)
+                    {
+                    }
+                    this.handlingException = false;
+                }));
+            }
+        }
+
+        private void OnAppDomainUnhandledException(object sender, UnhandledExceptionEventArgs e)
+        {
+            this.appLog.Error("Unhandled app domain exception", e.ExceptionObject as Exception);
+            if (!this.handlingException)
+            {
+                this.handlingException = true;
+                UiDispatcher.Invoke(new Action(() =>
+                {
+                    try
+                    {
+                        this.HandleUnhandledException(e.ExceptionObject);
+                    }
+                    catch (Exception)
+                    {
+                    }
+                    this.handlingException = false;
+                }));
+            }
+        }
+
+        private void TaskScheduler_UnobservedTaskException1(object sender, UnobservedTaskExceptionEventArgs e)
+        {
+            this.appLog.Error("Unhandled task scheduler exception", e.Exception);
+            if (!this.handlingException)
+            {
+                this.handlingException = true;
+                e.SetObserved();
+                UiDispatcher.Invoke(new Action(() =>
+                {
+                    try
+                    {
+                        this.HandleUnhandledException(e.Exception);
+                    }
+                    catch (Exception)
+                    {
+                    }
+                    this.handlingException = false;
+                }));
+            }
+        }
 
+        public bool HandleUnhandledException(object exceptionObject)
+        {
+            Exception ex = exceptionObject as Exception;
+            string message = null;
+            string details = null;
+            if (ex == null && exceptionObject != null)
+            {
+                ex = new Exception(exceptionObject.GetType().FullName + ": " + exceptionObject.ToString());
+            }
 
+            message = ex.Message;
+            details = ex.ToString();
 
+            try
+            {
+                MessageBoxEx.Show(message + " - " + Log.ReportLogging, "Unhandled Exception", details, MessageBoxButton.OK, MessageBoxImage.Error);
 
-    }
+                MainWindow mw = (MainWindow)Application.Current.MainWindow;
+                if (mw != null && mw.IsVisible)
+                {
+                    mw.SaveIfDirty("Unhandled exception, do you want to save your changes?", null);
+                }
+                return true;
+            }
+            catch (Exception)
+            {
+                // hmmm, if we can't show the dialog then perhaps this is some sort of stack overflow.
+                // save the details to a file, terminate the process 
+                this.appLog.FatalUnhandledException(message, ex);
+                return false;
+            }
+        }
 
+        private void TaskScheduler_UnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs e)
+        {
+            if (e.Exception != null)
+            {
+                this.HandleUnhandledException(e.Exception);
+            }
+            e.SetObserved();
+        }
 
+    }
 }

Source/WPF/MyMoney/Commands/Commands.cs

@@ -55,6 +55,7 @@ public static class AppCommands
         public static readonly RoutedUICommand CommandAddSampleData;
         public static readonly RoutedUICommand CommandTroubleshootCheckTransfer;
         public static readonly RoutedUICommand CommandViewChanges;
+        public static readonly RoutedUICommand CommandViewLogs;
 
         // ContextMenu on Graphs & Charts
         public static readonly RoutedUICommand CommandYearToDate;
@@ -124,6 +125,7 @@ static AppCommands()
             CommandAddSampleData = new RoutedUICommand("AddSampleData", "Add Sample Data", typeof(AppCommands));
             CommandTroubleshootCheckTransfer = new RoutedUICommand("TroubleshootCheckTransfer", "Check Transfer", typeof(AppCommands));
             CommandViewChanges = new RoutedUICommand("CommandViewChanges", "View Changes", typeof(AppCommands));
+            CommandViewLogs = new RoutedUICommand("CommandViewLogs", "View Logs", typeof(AppCommands));
 
             // Cusrtom Report range dialog
             CommandYearToDate = new RoutedUICommand("Year to date", "CommandYearToDate", typeof(AppCommands));

Source/WPF/MyMoney/Controls/MoneyDataGrid.cs

@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.ComponentModel;
+using System.Diagnostics;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Controls.Primitives;
@@ -649,45 +650,54 @@ public void ClearAutoEdit()
         /// </summary>
         public virtual bool MoveFocusToNextEditableField()
         {
-            if (this.SelectedItem == null)
+            if (this.SelectedItem == null || this.CurrentColumn== null)
             {
                 return false;
             }
 
-            // First check if the current column has more than one editable control.
-            FrameworkElement contentPresenter = this.CurrentColumn.GetCellContent(this.SelectedItem);
-            if (contentPresenter == null)
-            {
-                return false;
-            }
-            List<Control> editors = new List<Control>();
-            WpfHelper.FindEditableControls(contentPresenter, editors);
-
-            // Move focus to the next editor in the cell if there is one.  
-            // This can happen on the "Payee/Category/Memo" column which has 3 editors in one column.
-            for (int i = 0; i < editors.Count; i++)
+            try
             {
-                Control editor = editors[i];
-                if (editor.IsKeyboardFocusWithin && i + 1 < editors.Count)
+                // First check if the current column has more than one editable control.
+                FrameworkElement contentPresenter = this.CurrentColumn.GetCellContent(this.SelectedItem);
+                if (contentPresenter == null)
                 {
-                    editor = editors[i + 1];
-                    this.OnStartEdit(editor);
-                    return true;
+                    return false;
                 }
-            }
-            {
-                // Begin edit on the next column, and set focus on the text edit field and skip non-editable columns.
-                DataGridColumn c = this.CurrentColumn;
-                int i = this.Columns.IndexOf(c) + 1;
-                for (int n = this.Columns.Count; i < n; i++)
+                List<Control> editors = new List<Control>();
+                WpfHelper.FindEditableControls(contentPresenter, editors);
+
+                // Move focus to the next editor in the cell if there is one.  
+                // This can happen on the "Payee/Category/Memo" column which has 3 editors in one column.
+                for (int i = 0; i < editors.Count; i++)
                 {
-                    DataGridColumn next = this.Columns[i];
-                    if (next != null && !next.IsReadOnly)
+                    Control editor = editors[i];
+                    if (editor.IsKeyboardFocusWithin && i + 1 < editors.Count)
                     {
-                        this.CurrentColumn = next;
+                        editor = editors[i + 1];
+                        this.OnStartEdit(editor);
                         return true;
                     }
                 }
+
+                {
+                    // Begin edit on the next column, and set focus on the text edit field and skip non-editable columns.
+                    DataGridColumn c = this.CurrentColumn;
+                    int i = this.Columns.IndexOf(c) + 1;
+                    for (int n = this.Columns.Count; i < n; i++)
+                    {
+                        DataGridColumn next = this.Columns[i];
+                        if (next != null && !next.IsReadOnly)
+                        {
+                            this.CurrentColumn = next;
+                            return true;
+                        }
+                    }
+                }
+            }
+            catch (Exception ex)
+            {
+                Debug.WriteLine("Unhandled exception in MoveFocusToNextEditableField: " + ex.Message);
+                // customers reporting NullReferenceExceptions from this code, so protecting it with try/catch.
             }
             return false;
         }

Source/WPF/MyMoney/Controls/OfxDownloadControl.xaml.cs

@@ -278,7 +278,8 @@ private void OnDetailsClick(object sender, RoutedEventArgs e)
 
         private void GetNewPassword(OfxDownloadData ofxData)
         {
-            var info = OfxRequest.GetSignonInfo(this.myMoney, ofxData.OnlineAccount);
+            var req = new OfxRequest(ofxData.OnlineAccount, this.myMoney, null);
+            var info = req.GetSignonInfo();
 
             ChangePasswordDialog dialog = new ChangePasswordDialog(info, ofxData.OnlineAccount, this.myMoney);
             dialog.Owner = Application.Current.MainWindow;
@@ -306,7 +307,8 @@ private void GetNewPassword(OfxDownloadData ofxData)
 
         private void GetLogin(OfxDownloadData ofxData)
         {
-            var info = OfxRequest.GetSignonInfo(this.myMoney, ofxData.OnlineAccount);
+            var req = new OfxRequest(ofxData.OnlineAccount, this.myMoney, null);
+            var info = req.GetSignonInfo();
 
             string msg = (ofxData.Error != null) ? ofxData.Error.Message : null;
 
@@ -388,7 +390,8 @@ private void OnChallengeCompleted(object sender, EventArgs e)
 
         private void GetAuthenticationToken(OfxDownloadData ofxData, OfxErrorCode code)
         {
-            var info = OfxRequest.GetSignonInfo(this.myMoney, ofxData.OnlineAccount);
+            var req = new OfxRequest(ofxData.OnlineAccount, this.myMoney, null);
+            var info = req.GetSignonInfo();
             if (info != null)
             {
                 this.PromptForAuthToken(ofxData, info, code);

Source/WPF/MyMoney/Database/CsvStore.cs

@@ -171,7 +171,7 @@ public static void WriteTransaction(StreamWriter writer, Transaction t, Optional
             {
                 writer.Write(",\"{0}\"", CsvSafeString(t.GetAccountCurrency().Symbol));
             }
-            writer.WriteLine(",\"{0}\"", CsvSafeString("" + t.Memo));
+            writer.WriteLine(",\"{0}\"", CsvSafeString(t.Memo));
         }
 
         public static void WriteInvestmentHeader(StreamWriter writer)
@@ -203,7 +203,7 @@ public static void WriteInvestment(StreamWriter writer, Investment i)
                 CsvSafeString(t.InvestmentUnits.ToString()),
                 CsvSafeString(t.InvestmentUnitPrice.ToString("C2")),
                 CsvSafeString(t.Amount.ToString("C2")),
-                CsvSafeString("" + t.Memo));
+                CsvSafeString(t.Memo));
         }
 
         public static void WriteLoanPaymentHeader(StreamWriter writer)
@@ -232,6 +232,10 @@ public virtual void Backup(string path)
 
         public static string CsvSafeString(string s)
         {
+            if (string.IsNullOrEmpty(s))
+            {
+                return "";
+            }
             // everything is going inside double quotes, so we have to protect any existing double quotes
             // which is done by replacing them with 2 quotes like this "".
             s = s.Replace("\"", "\"\"");