Issue151 monetdbe bind #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed connection boilerplate code - fixed/updated unit tests
|
awesome, green! thanks, will have a look |
gijzelaerr
reviewed
Sep 7, 2021
gijzelaerr
reviewed
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should accommodate the recently introduced API changes in monetdbe_prepare. First is to make sure that there are no regressions. Hopefully the CI can confirm that this is the current situation.
While developing my API accommodations I was hitting problems in the connection boilerplate causing regressions on my own system while running the unit tests. I think I have fixed what needed to be fixed there. Ideally this should have been fixed in a separate PR. But life is hard sometimes. The unit tests are accordingly fixed/restructured.
Next step is to actually make sensible use of the new API changes. But again first lets see how the current PR survives the CI.