fix ltx2 stop_signal -> mermory leak

[huochaitiantang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential memory leak issue in the base_runner.py module. By explicitly invoking the end_run method when a stop or pause signal is received, the system can properly release resources. This ensures that memory is not accumulated over time, particularly during unexpected terminations, thereby improving the stability and resource management of the application.

Highlights

• Memory Leak Prevention: Introduced calls to self.end_run() within the check_stop method when stop_signal or pause_signal is detected, ensuring proper resource cleanup before raising an exception.
• Robust Error Handling: Wrapped the self.end_run() calls in try-except blocks to gracefully handle and log any potential failures during the cleanup process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• lightx2v/models/runners/base_runner.py
  • Added self.end_run() calls before raising exceptions for stop and pause signals to ensure proper resource cleanup.
  • Wrapped self.end_run() calls in try-except blocks to log any exceptions that might occur during the cleanup process.

Activity

• No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a potential memory leak by ensuring end_run() is called to clean up resources when a stop or pause signal is received. The implementation introduces some code duplication for handling the stopped and paused states. My feedback suggests refactoring this to a single block to improve code clarity and maintainability. I also recommend using a standard logger instead of print for error messages.

[gemini-code-assist]

The logic for handling stopped and paused signals is duplicated. You can combine them to improve readability and maintainability by calling end_run once and then raising the appropriate exception.

Additionally, consider using a proper logger (like loguru which is used elsewhere in the project, or the standard logging module) instead of print() for error messages. This allows for better control over log levels, formatting, and output destinations.

Suggested change

	if stopped == 1:
	try:
	self.end_run()
	except Exception as e:
	print(f"end_run failed: {e}")
	raise Exception(f"find rank: {rank} stop_signal, stop running, it's an expected behavior")
	if paused == 1:
	try:
	self.end_run()
	except Exception as e:
	print(f"end_run failed: {e}")
	raise Exception(f"find rank: {rank} pause_signal, pause running, it's an expected behavior")
	if stopped == 1 or paused == 1:
	try:
	self.end_run()
	except Exception as e:
	# TODO: Consider using a logger for better error handling.
	print(f"end_run failed: {e}")
	if stopped == 1:
	raise Exception(f"find rank: {rank} stop_signal, stop running, it's an expected behavior")
	else: # This is only reached if stopped != 1 and paused == 1
	raise Exception(f"find rank: {rank} pause_signal, pause running, it's an expected behavior")