Skip to content

update readme#563

Merged
helloyongyang merged 1 commit intomainfrom
hh
Dec 4, 2025
Merged

update readme#563
helloyongyang merged 1 commit intomainfrom
hh

Conversation

@helloyongyang
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @helloyongyang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the accuracy of the project's documentation by revising the performance benchmark tables in both the English and Chinese README files. The changes specifically address the single-card configuration, providing updated and corrected metrics for certain frameworks to ensure users have the most current and precise performance information.

Highlights

  • Performance Metrics Update: Updated the 'Step Time' and 'Speedup' values for 'FastVideo' and 'SGL-Diffusion' in the 1-card configuration within the performance benchmark tables.
  • Table Reordering: Adjusted the order of entries for 'FastVideo' and 'xDiT' in the 1-card performance benchmark tables for better presentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@helloyongyang helloyongyang merged commit be303ba into main Dec 4, 2025
2 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the benchmark data in the README.md and README_zh.md files. The changes appear to correct the performance metrics for FastVideo and SGL-Diffusion. I've added a suggestion to reorder the rows in the benchmark table for consistency and better readability, ensuring it's sorted by performance like the other tables in the document.

Comment on lines 52 to 54
| xDiT | 1 | OOM | OOM |
| FastVideo | 1 | OOM | OOM |
| SGL-Diffusion | 1 | 22.66s/it | 1.3x |
| SGL-Diffusion | 1 | OOM | OOM |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for updating the benchmark data. To maintain consistency with the other performance tables (like the H100 benchmark), it would be clearer to sort the rows by performance, from slowest to fastest (Step Time descending), with 'OOM' results at the end. Currently, LightX2V is at the bottom of the 1-card group, but it's the fastest in this category.

Suggested change
| xDiT | 1 | OOM | OOM |
| FastVideo | 1 | OOM | OOM |
| SGL-Diffusion | 1 | 22.66s/it | 1.3x |
| SGL-Diffusion | 1 | OOM | OOM |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
| xDiT | 1 | OOM | OOM |
| SGL-Diffusion | 1 | OOM | OOM |

Comment on lines 52 to 54
| xDiT | 1 | OOM | OOM |
| FastVideo | 1 | OOM | OOM |
| SGL-Diffusion | 1 | 22.66s/it | 1.3x |
| SGL-Diffusion | 1 | OOM | OOM |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for updating the benchmark data. To maintain consistency with the other performance tables (like the H100 benchmark), it would be clearer to sort the rows by performance, from slowest to fastest (Step Time descending), with 'OOM' results at the end. Currently, LightX2V is at the bottom of the 1-card group, but it's the fastest in this category.

Suggested change
| xDiT | 1 | OOM | OOM |
| FastVideo | 1 | OOM | OOM |
| SGL-Diffusion | 1 | 22.66s/it | 1.3x |
| SGL-Diffusion | 1 | OOM | OOM |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
| **LightX2V** | 1 | **20.26s/it** | **1.5x** 🚀 |
| xDiT | 1 | OOM | OOM |
| SGL-Diffusion | 1 | OOM | OOM |

@helloyongyang helloyongyang deleted the hh branch December 28, 2025 16:05
helloyongyang added a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant