Remove manual serialization for messages #153
Conversation
| return instances[wallet.url] ?: CoinbaseWalletSDK( | ||
| hostPackageName = wallet.packageName, | ||
| scheme = wallet.url, | ||
| keyManager = KeyManager(ClientConfiguration.config.context, wallet.packageName) | ||
| ) | ||
| } | ||
|
|
||
| fun handleResponse(uri: Uri): Boolean { | ||
| @JvmStatic | ||
| fun handleResponseUrl(uri: Uri): Boolean { |
There was a problem hiding this comment.
Changed name here to prevent naming clash when marking function with @JvmStatic
|
|
||
| typealias UnencryptedRequestMessage = Message<UnencryptedRequestContent> | ||
|
|
||
| sealed interface RequestContent { |
There was a problem hiding this comment.
Keeping this RequestContent to keep interface CoinbaseWalletSDK.makeRequest the same
| "Must initialize open intent callback before getting CoinbaseWalletSDK instance" | ||
| ) | ||
| if (openIntent == null) { | ||
| throw IllegalStateException("Must initialize open intent callback before getting CoinbaseWalletSDK instance") |
There was a problem hiding this comment.
Changed this to throw IllegalStateException because this error is not returned from the wallet
| import java.security.interfaces.ECPrivateKey | ||
| import java.security.interfaces.ECPublicKey | ||
|
|
||
| object RequestConverter : MessageConverter<UnencryptedRequestMessage, EncryptedRequestMessage> { |
There was a problem hiding this comment.
There is some code duplication with RequestConverter and ResponseConverter, but I was not able to get the kotlin serialization library to play nicely with generic types.
| @@ -14,13 +14,16 @@ data class Wallet( | |||
| } | |||
|
|
|||
| object DefaultWallets { | |||
There was a problem hiding this comment.
not a scope for this pr, but i think we might just consolidate Wallet and DefaultWallets into one, with the thing called companion object or something on kotlin world.
on swift, those default wallets and static method to get those are defined under Wallet
Summary
How did you test your changes?
Tested manually with CB Wallet to make sure changes are backwards compatible with older versions