Emit events for host library actions & misc fixes #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnumad
commented
Nov 19, 2022
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "trailingComma": "all", |
There was a problem hiding this comment.
Matches prettier style used by CB internally
vishnumad
commented
Nov 19, 2022
| }, | ||
| "dependencies": { | ||
| "buffer": "^6.0.3", | ||
| "react-native-url-polyfill": "^1.3.0" |
There was a problem hiding this comment.
Polyfills URL and Buffer which don't have complete implementations in React Native
vishnumad
force-pushed
the
vishnu/sdk-events
branch
from
f681a6b to
6cefa58
Compare
bangtoven
reviewed
Nov 21, 2022
| | SendSuccessResponseEvent | ||
| | SendFailureResponseEvent; | ||
|
|
||
| const events = new EventEmitter(); |
There was a problem hiding this comment.
|
Looks mostly good. I would normally advise splitting up any formatting into separate PR, but this is fine for the PR size. |
AMITGOELNY
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
URLandBufferwhich aren't in React Native by defaultgetAndroidIntentUrlHow did you test your changes?