-
Notifications
You must be signed in to change notification settings - Fork 111
slightly loosen ProgressMeter compat #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We want to avoid 1.10.3, but I don't think there is a strong reason to prevent future patch releases.
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Unfortunately ProgressMeter.jl does not follow SemVer: https://github.com/timholy/ProgressMeter.jl/releases/tag/v1.10.1 (multiple features added on a patch release) so I think we should treat every patch release as breaking. Especially since it's such a key dependency in both SymbolicRegression.jl and PySR, I really don't think we can afford such a risk. |
@timholy would it be possible for ProgressMeter to more closely semver things? (specifically making minor releases for new features). |
@MarcMush (new features should use a minor version bump) |
(just to clarify I'm not a maintainer of ProgressMeter, just a drive-by contributor 😛 ) |
@timholy yes I will be more careful |
We want to avoid 1.10.3, but I don't think there is a strong reason to prevent future patch releases.