Skip to content

Fix mistakes in .openpublishing.redirection.json #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .openpublishing.redirection.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"redirect_document_id": true
},
{
"source_path": "docs/supported-platforms-visual-cpp.md.md",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra .md causes the redirection to not work (same for the other occurrence).

"source_path": "docs/supported-platforms-visual-cpp.md",
"redirect_url": "/cpp/overview/supported-platforms-visual-cpp",
"redirect_document_id": true
},
Expand Down Expand Up @@ -7436,7 +7436,7 @@
"redirect_document_id": false
},
{
"source_path": "docs/dotnet/how-to-enumerate-data-types-in-assemblies-using-reflection-cpp-cli.md.md",
"source_path": "docs/dotnet/how-to-enumerate-data-types-in-assemblies-using-reflection-cpp-cli.md",
"redirect_url": "/cpp/dotnet/reflection-cpp-cli#enumerate",
"redirect_document_id": false
},
Expand Down Expand Up @@ -13752,12 +13752,12 @@
},
{
"source_path": "docs/c-runtime-library/operator-delete-crt.md",
"redirect_url": "docs/c-runtime-library/delete-operator-crt",
"redirect_url": "/cpp/c-runtime-library/delete-operator-crt",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old redirect_url redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-delete-crt to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/delete-operator-crt, leading to a 404.

"redirect_document_id": false
},
{
"source_path": "docs/c-runtime-library/operator-new-crt.md",
"redirect_url": "docs/c-runtime-library/new-operator-crt",
"redirect_url": "/cpp/c-runtime-library/new-operator-crt",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old redirect_url redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-new-crt to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/new-operator-crt, leading to a 404.

"redirect_document_id": false
},
{
Expand Down