Skip to content

Add missing square brackets for [[nodiscard]] in C4834 reference #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

Add missing ] for [[nodiscard]].

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 96ec681:

✅ Validation status: passed

File Status Preview URL Details
docs/error-messages/compiler-warnings/c4834.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@TylerMSFT - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 16, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone inadvertently discarded the ] even though it clearly said nodiscard! ;-)

@TylerMSFT
Copy link
Collaborator

#sign-off

@v-dirichards v-dirichards merged commit 39c5502 into MicrosoftDocs:main Jun 25, 2025
2 checks passed
@Rageking8 Rageking8 deleted the add-missing-square-brackets-for-nodiscard-in-c4834-reference branch June 26, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants