Skip to content

Provide more guidance for file encoding #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

Provide more guidance for file encoding #285

merged 2 commits into from
Jan 7, 2025

Conversation

sdwheeler
Copy link
Collaborator

@sdwheeler sdwheeler commented Jan 7, 2025 •
edited by azure-boards bot
Loading

Provide more guidance for file encoding

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit c3d279a:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/PSScriptAnalyzer/Rules/UseBOMForUnicodeEncodedFile.md ✅Succeeded View (ps-modules)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 3ccd272:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/PSScriptAnalyzer/Rules/UseBOMForUnicodeEncodedFile.md ✅Succeeded View (ps-modules)
reference/docs-conceptual/PSScriptAnalyzer/Rules/UseUTF8EncodingForHelpFile.md ✅Succeeded View (ps-modules)

For more details, please refer to the build report.

For any questions, please:

mikefrobbins
mikefrobbins approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikefrobbins mikefrobbins merged commit f2fcf42 into MicrosoftDocs:main Jan 7, 2025
3 checks passed
@sdwheeler sdwheeler deleted the sdw-w262079-uuf branch January 7, 2025 20:07
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 15, 2025
@bergmeister
Backport msdocs changes for Cmdlets. Where references to files in MSD…
7543854 
…ocs were present (e.g. in UseShouldProcessForStateChangingFunctions), replaced with the live URLs. Did not port back TODO block of AvoidAssignmentToAutomaticVariable.md from https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/241/files#diff-1db3dc2f98da1fa58e24bac28ea9f14f507c78d8299349aa0196f01f9479b6f5

Backported PRs:
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/281/files
- MicrosoftDocs/PowerShell-Docs-Modules@ff80de6
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/275/files
- MicrosoftDocs/PowerShell-Docs-Modules#278
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/235/files
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/276/files
- MicrosoftDocs/PowerShell-Docs-Modules#273
- MicrosoftDocs/PowerShell-Docs-Modules#285
- MicrosoftDocs/PowerShell-Docs-Modules@6ca872b#diff-b3e50d455fe1b464a6fec38ac616cbde4a412766a05a606c1ae55be90ccb63a3
- MicrosoftDocs/PowerShell-Docs-Modules#277
@bergmeister bergmeister mentioned this pull request Mar 15, 2025
Merged
6 tasks
sdwheeler pushed a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 15, 2025
@bergmeister @sdwheeler
Backport msdocs changes for Cmdlets. Where references to files in MSD…
9e546e4 
…ocs were present (e.g. in UseShouldProcessForStateChangingFunctions), replaced with the live URLs. Did not port back TODO block of AvoidAssignmentToAutomaticVariable.md from https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/241/files#diff-1db3dc2f98da1fa58e24bac28ea9f14f507c78d8299349aa0196f01f9479b6f5

Backported PRs:
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/281/files
- MicrosoftDocs/PowerShell-Docs-Modules@ff80de6
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/275/files
- MicrosoftDocs/PowerShell-Docs-Modules#278
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/235/files
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/276/files
- MicrosoftDocs/PowerShell-Docs-Modules#273
- MicrosoftDocs/PowerShell-Docs-Modules#285
- MicrosoftDocs/PowerShell-Docs-Modules@6ca872b#diff-b3e50d455fe1b464a6fec38ac616cbde4a412766a05a606c1ae55be90ccb63a3
- MicrosoftDocs/PowerShell-Docs-Modules#277
andyleejordan pushed a commit to PowerShell/PSScriptAnalyzer that referenced this pull request Mar 17, 2025
@bergmeister @sdwheeler
Backport MSDocs changes (#2085)
28081e5 
* Backport docs updates from docs repo

* Backport msdocs changes for Cmdlets. Where references to files in MSDocs were present (e.g. in UseShouldProcessForStateChangingFunctions), replaced with the live URLs. Did not port back TODO block of AvoidAssignmentToAutomaticVariable.md from https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/241/files#diff-1db3dc2f98da1fa58e24bac28ea9f14f507c78d8299349aa0196f01f9479b6f5
Backported PRs:
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/281/files
- MicrosoftDocs/PowerShell-Docs-Modules@ff80de6
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/275/files
- MicrosoftDocs/PowerShell-Docs-Modules#278
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/235/files
- https://github.com/MicrosoftDocs/PowerShell-Docs-Modules/pull/276/files
- MicrosoftDocs/PowerShell-Docs-Modules#273
- MicrosoftDocs/PowerShell-Docs-Modules#285
- MicrosoftDocs/PowerShell-Docs-Modules@6ca872b#diff-b3e50d455fe1b464a6fec38ac616cbde4a412766a05a606c1ae55be90ccb63a3
- MicrosoftDocs/PowerShell-Docs-Modules#277

* Update docs/Cmdlets/Invoke-ScriptAnalyzer.md

Co-authored-by: Christoph Bergmeister <[email protected]>

* Apply suggestions from code review

Co-authored-by: Christoph Bergmeister <[email protected]>

---------

Co-authored-by: Sean Wheeler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikefrobbins mikefrobbins mikefrobbins approved these changes

@michaeltlombardi michaeltlombardi Awaiting requested review from michaeltlombardi michaeltlombardi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdwheeler @mikefrobbins