Add ordered set analyzer commands #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunth
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
I only did a very cursory look. Lots of code here. Seems reasonable from a high level.
One issue is the patches appear to be out of order seeing the first patch uses convert_hex_str() which is introduced by the second patch.
There used to be continuous integration on this project to prevent things like this. Seems to be broken now.
kelvin-cao
reviewed
Jul 4, 2025
kelvin-cao
reviewed
Jul 4, 2025
renamed the convert_str_to_dword function to convert_hex_str, now instead of a hardcoded max length of 8 or dword, now applies to more general hex strings, can be defined depending on the hex being decoded using hex_len_max param
BenReed161
force-pushed
the
add-ordered-set-analyzer-commands
branch
2 times, most recently
from
20a98dc to
1e816e8
Compare
Add requested OSA ordered set analyzer coammnds to the switchtec user commands to handle OSA split into 7 commands which reflect each MRPC sub command as part of the OSA group. osa - command which triggers specific osa operations on a given stack osa config type - configure the osa type 4 different masks. Lane mask to trigger on specific lanes, a directional mask, a link rate mask, and ordered set type mask, each on a given stack osa config pattern - configure osa pattern with similar masks as previous minus a directional mask. Value and mask dwords are added to configure the value of the pattern and the mask for the pattern. The corresponding bit in the pattern value is used for matching. osa config misc - This is for triggering the configuration on trigger types not covered by the previous two commands. There a trigger enable mask for 3 corresponding types: LTMON, other HW blocks, general purpose. osa capture control - This command allows the user to control how the OSA is captured along lane and direction using masks as well how many entries to capture, what types, and specific modes to capture on. osa dump config - This command will dump the config on the specified stack. osa dump data - This command will dump the data for the osa given a lane mask and directional mask, for a specific stack.
BenReed161
force-pushed
the
add-ordered-set-analyzer-commands
branch
from
1e816e8 to
d660bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ordered set commands
Add requested OSA ordered set analyzer coammnds to the switchtec user
commands to handle OSA split into 7 commands which reflect each MRPC
sub command as part of the OSA group.
osa - command which triggers specific osa operations on a given stack
osa config type - configure the osa type 4 different masks. Lane mask
to trigger on specific lanes, a directional mask, a link rate mask, and
ordered set type mask, each on a given stack
osa config pattern - configure osa pattern with similar masks as
previous minus a directional mask. Value and mask dwords are added to
configure the value of the pattern and the mask for the pattern.
The corresponding bit in the pattern value is used for matching.
osa config misc - This is for triggering the configuration on trigger
types not covered by the previous two commands. There a trigger enable
mask for 3 corresponding types: LTMON, other HW blocks, general
purpose.
osa capture control - This command allows the user to control how the
OSA is captured along lane and direction using masks as well how many
entries to capture, what types, and specific modes to capture on.
osa dump config - This command will dump the config on the specified
stack.
osa dump data - This command will dump the data for the osa given a
lane mask and directional mask, for a specific stack.