Skip to content

Bump transaction-controller peer dep to v58 #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jul 3, 2025

This package was previously on a rather old version of transaction-controller (v42). This commit ensures that clients can upgrade to v58 without peer dependency warnings.

Closes #513.

This package was previously on a rather old version of
`transaction-controller` (v42). This commit ensures that clients can
upgrade to v58 without peer dependency warnings.
@mcmire mcmire force-pushed the upgrade-transaction-controller-to-v58 branch from 97a47be to 74b8c3b Compare July 3, 2025 18:40
Copy link

socket-security bot commented Jul 3, 2025

Copy link

socket-security bot commented Jul 3, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@mcmire
Copy link
Contributor Author

mcmire commented Jul 3, 2025

@SocketSecurity ignore npm/@metamask/[email protected]

This is our package.

@mcmire mcmire marked this pull request as ready for review July 3, 2025 18:46
@mcmire mcmire requested a review from a team as a code owner July 3, 2025 18:46
cursor[bot]

This comment was marked as outdated.

@mcmire
Copy link
Contributor Author

mcmire commented Jul 3, 2025

We'll need to make a draft PR for Extension and Mobile that tests this upgrade to complete this.

@mcmire
Copy link
Contributor Author

mcmire commented Jul 3, 2025

@cursor This is intentional.

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump @metamask/transaction-controller to 54.x
2 participants