feat: update controller to inherit from BaseControllerV2 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, | ||
|
|
||
| this.update((state) => { | ||
| state.smartTransactionsState.smartTransactions[chainId][currentIndex] = { |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
There was a problem hiding this comment.
@legobeat any thoughts on how to fix this issue ?
mikesposito
reviewed
Aug 16, 2024
MajorLift
reviewed
Aug 19, 2024
MajorLift
reviewed
Aug 19, 2024
MajorLift
reviewed
Aug 19, 2024
MajorLift
reviewed
Aug 20, 2024
MajorLift
reviewed
Aug 20, 2024
MajorLift
reviewed
Aug 20, 2024
MajorLift
reviewed
Aug 22, 2024
cryptodev-2s
dismissed
MajorLift’s stale review
The merge-base changed after approval.
MajorLift
approved these changes
Aug 22, 2024
MajorLift
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartTransactionController has been updated to inherit from
StaticIntervalPollingControllerinstead ofStaticIntervalPollingControllerV2Fixes #385