Skip to content

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Aug 25, 2025

Description

This PR adds a new component MultichainAccountConnectedList for the bip44 dapp connection flow. It is currently not wired up and cannot be used. The only way to test is to use storybook.

Changelog

CHANGELOG entry: null

Related issues

Related to: https://consensyssoftware.atlassian.net/browse/MUL-669?atlOrigin=eyJpIjoiYzNhZGVkYWFhMGUyNDA2Zjg3N2EyZmVjZjJkNWM4YjIiLCJwIjoiaiJ9

Manual testing steps

It is only testable on storybook.

Screenshots/Recordings

After

Simulator Screenshot - iPhone 15 Pro - 2025-08-25 at 20 52 16 Simulator Screenshot - iPhone 15 Pro - 2025-08-25 at 20 52 22 Simulator Screenshot - iPhone 15 Pro - 2025-08-25 at 20 52 27

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev force-pushed the feat/multichain-accounts-connected-list branch from 46d32cb to a8e6213 Compare August 25, 2025 12:53
@montelaidev montelaidev marked this pull request as ready for review August 25, 2025 14:02
@montelaidev montelaidev requested a review from a team as a code owner August 25, 2025 14:02
<View style={styles.container}>
<View style={styles.accountsConnectedContainer}>
<FlashList
key={`flashlist-${selectedAccountGroups.length}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this key is needed.

owencraston
owencraston previously approved these changes Aug 25, 2025
@montelaidev montelaidev enabled auto-merge August 25, 2025 23:44
@montelaidev montelaidev added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels Aug 25, 2025
Copy link
Contributor

github-actions bot commented Aug 25, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 88eab7e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5b701caf-6e19-451a-9273-886017060b1d

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@montelaidev montelaidev added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Aug 26, 2025
Copy link
Contributor

github-actions bot commented Aug 26, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b1ad452
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f216b7ee-827e-4e7e-9229-2d6f2287b471

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Copy link

@montelaidev montelaidev added this pull request to the merge queue Aug 26, 2025
auto-merge was automatically disabled August 26, 2025 13:52

Pull Request is not mergeable

Merged via the queue into main with commit e6589d3 Aug 26, 2025
67 of 71 checks passed
@montelaidev montelaidev deleted the feat/multichain-accounts-connected-list branch August 26, 2025 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.55.0 Issue or pull request that will be included in release 7.55.0 Run Smoke E2E Requires smoke E2E testing size-L team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants