-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat: removes bridge button when unified is enabled #33970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [679b89f]
UI Startup Metrics (1188 ± 57 ms)
Benchmark value 2205 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2551 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 411 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 1680 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1628 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1373 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2048 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 80ms | Sum of p95 exceeds: 480ms Sum of all benchmark exceeds: 560ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Jun 27, 2025
SteP-n-s
approved these changes
Jun 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.23.0
Issue or pull request that will be included in release 12.23.0
team-swaps-and-bridge
Swaps and Bridge team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes the bridge button when unified swaps is enabled as it is redundant. this change is necessary because the GNS removal + homepage redesign is being delayed.
Related issues
Closes: https://consensyssoftware.atlassian.net/browse/SWAPS-2541
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist