Skip to content

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Jun 27, 2025

Description

removes the bridge button when unified swaps is enabled as it is redundant. this change is necessary because the GNS removal + homepage redesign is being delayed.

Open in GitHub Codespaces

Related issues

Closes: https://consensyssoftware.atlassian.net/browse/SWAPS-2541

Manual testing steps

  1. Go to the homepage or an asset page.
  2. If unified is enabled, bridge button will not be visible, and the buttons should still be aligned correctly.

Screenshots/Recordings

Before

Screenshot 2025-06-27 at 2 10 35 PM

After

Screenshot 2025-06-27 at 2 10 12 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jun 27, 2025
@ghgoodreau ghgoodreau marked this pull request as ready for review June 27, 2025 19:11
@metamaskbot
Copy link
Collaborator

Builds ready [679b89f]
UI Startup Metrics (1188 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1188107713735712251310
load102191911835310531106
domContentLoaded101391111785410471097
domInteractive18144861735
firstPaint736166118638410421105
backgroundConnect84326825
firstReactRender21164142230
getState1463271928
initialActions001001
loadScripts80870597154842892
setupStore85263914
WebpackHomeuiStartup22051719274619222982551
load16811275206816017651963
domContentLoaded16751271205215917621949
domInteractive1812102161360
firstPaint1746960173190303
backgroundConnect3010285522453
firstReactRender23390431118382411
getState144315311225
initialActions217134
loadScripts16721270204115817601940
setupStore1575371728
FirefoxBrowserifyHomeuiStartup13711203209913614381680
load1197106715899712571358
domContentLoaded1197106715899712561358
domInteractive1113643855123189
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2514177212359
firstReactRender24224232529
getState11518519927
initialActions001001
loadScripts1177105315619412381344
setupStore947410818
WebpackHomeuiStartup16281420228419117402048
load13941216186915215041693
domContentLoaded13941216186915215041693
domInteractive95343205397283
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615253242442
firstReactRender43326344548
getState187237291334
initialActions002111
loadScripts13721196185114814841630
setupStore12526528828
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2205 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2551 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 411 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 1680 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1628 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1373 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2048 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1693 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Sum of mean exceeds: 80ms | Sum of p95 exceeds: 480ms
Sum of all benchmark exceeds: 560ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 162.79 KiB (3.04%)
  • ui: 18.96 KiB (0.26%)
  • common: 20.39 KiB (0.24%)

@micaelae micaelae added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 27d7ea1 Jun 30, 2025
168 of 169 checks passed
@micaelae micaelae deleted the SWAPS-2541-bridge-button-removal-with-unified branch June 30, 2025 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
@metamaskbot metamaskbot added the release-12.23.0 Issue or pull request that will be included in release 12.23.0 label Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.23.0 Issue or pull request that will be included in release 12.23.0 team-swaps-and-bridge Swaps and Bridge team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants