-
Notifications
You must be signed in to change notification settings - Fork 5.3k
fix: Aggregated balance for enabled networks #33967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gambinish
merged 2 commits into
feat/network-manager-UI-2
from
fix/fix-aggregated-balance
Jun 30, 2025
Merged
fix: Aggregated balance for enabled networks #33967
gambinish
merged 2 commits into
feat/network-manager-UI-2
from
fix/fix-aggregated-balance
Jun 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [bd9c95a]
UI Startup Metrics (1191 ± 60 ms)
Benchmark value 2208 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 241 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2618 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1472 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1281 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1280 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1258 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1816 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 350 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1643 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1414 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1413 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1394 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2206 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1776 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1775 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1758 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 63 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 365ms | Sum of p95 exceeds: 1343ms Sum of all benchmark exceeds: 1708ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [52e0de5]
UI Startup Metrics (1210 ± 77 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2214 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 263 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2689 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1984 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1469 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1279 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1278 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1257 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1736 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 311 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1699 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1457 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1457 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 22 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1436 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2189 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1843 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1842 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 147 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1823 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 585ms | Sum of p95 exceeds: 1610ms Sum of all benchmark exceeds: 2195ms |
Builds ready [9841118]
UI Startup Metrics (1190 ± 62 ms)
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2243 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 242 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2668 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1976 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1695 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 327 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 62 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1679 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1417 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2203 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1832 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1832 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1807 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 328ms | Sum of p95 exceeds: 1405ms Sum of all benchmark exceeds: 1733ms |
fce492f
to
93d127b
Compare
Builds ready [93d127b]
UI Startup Metrics (1221 ± 76 ms)
Benchmark value 47 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 2596 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1411 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 128 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1682 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1648 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1396 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2056 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1690 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1675 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 185ms | Sum of p95 exceeds: 720ms Sum of all benchmark exceeds: 905ms |
Builds ready [9eb4a15]
UI Startup Metrics (1207 ± 83 ms)
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 984 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2545 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1983 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1670 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 286 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 79 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2062 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1756 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1756 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 314 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1738 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 28ms | Sum of p95 exceeds: 948ms Sum of all benchmark exceeds: 976ms |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: #33936
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist