Skip to content

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jun 27, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: #33936

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the base branch from main to feat/network-manager-UI-2 June 27, 2025 17:21
@metamaskbot
Copy link
Collaborator

Builds ready [bd9c95a]
UI Startup Metrics (1191 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1191110014136012171308
load102191712385810451120
domContentLoaded101591112325710391108
domInteractive17144151735
firstPaint708134124140110371111
backgroundConnect74304812
firstReactRender22173942330
getState1563572029
initialActions001001
loadScripts808707101956831904
setupStore95224819
WebpackHomeuiStartup22071635284421923162618
load16781221217818717761969
domContentLoaded16721216215918617671951
domInteractive181292151359
firstPaint1616544067174283
backgroundConnect2512274282740
firstReactRender24188421113374402
getState1244271528
initialActions217134
loadScripts16691215214818517651942
setupStore207301331839
FirefoxBrowserifyHomeuiStartup14721295191213015111816
load1280111714988813401458
domContentLoaded1280111714988813391458
domInteractive1263751780133350
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2713277302460
firstReactRender27225542832
getState155193261037
initialActions002001
loadScripts1258109914788813231436
setupStore13440241838
WebpackHomeuiStartup16421422230320917422206
load14131214204316915171776
domContentLoaded14131213204316915171775
domInteractive105324667097299
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2516321302337
firstReactRender42326244548
getState156187221232
initialActions002111
loadScripts13941194202416914991758
setupStore15536638863
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2208 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 241 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2618 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1472 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1281 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1280 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1258 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1816 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 350 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1643 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1414 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1413 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1394 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2206 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1776 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1775 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1758 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 63 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 365ms | Sum of p95 exceeds: 1343ms
Sum of all benchmark exceeds: 1708ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 154 Bytes (0%)
  • ui: 37.54 KiB (0.52%)
  • common: 294 Bytes (0%)

@gambinish gambinish changed the title Fix/fix aggregated balance fix: Aggregated balance for enabled networks Jun 27, 2025
@gambinish gambinish marked this pull request as ready for review June 27, 2025 20:59
@metamaskbot
Copy link
Collaborator

Builds ready [52e0de5]
UI Startup Metrics (1210 ± 77 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1210110016867712461331
load103591914707110631149
domContentLoaded102891614667110551141
domInteractive19146591744
firstPaint66285147641510361103
backgroundConnect84345914
firstReactRender23184962435
getState1566092132
initialActions001001
loadScripts820712124869849932
setupStore95244920
WebpackHomeuiStartup22131671283122723392689
load16591259214319517702007
domContentLoaded16531254212519417661995
domInteractive181283141457
firstPaint17560847109197321
backgroundConnect3010288432942
firstReactRender26390542123386406
getState164316311433
initialActions215134
loadScripts16491252211319317641984
setupStore207340332034
FirefoxBrowserifyHomeuiStartup14681249219214415331736
load1278110415089913551464
domContentLoaded1278110415079913551464
domInteractive1273648067135311
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515128162453
firstReactRender27225642832
getState145212241044
initialActions001001
loadScripts1256108814849613361408
setupStore144329351033
WebpackHomeuiStartup16991405255322117912189
load14571180192116815651843
domContentLoaded14561180192016815651842
domInteractive1123338072101302
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2516103132454
firstReactRender44327554651
getState2252644512147
initialActions102111
loadScripts14361162190616715341823
setupStore16530136949
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2214 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 263 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2689 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1984 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1469 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1279 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1278 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1257 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1736 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 311 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1699 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1457 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1457 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 22 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1436 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2189 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1843 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1842 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 147 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1823 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 585ms | Sum of p95 exceeds: 1610ms
Sum of all benchmark exceeds: 2195ms

@metamaskbot
Copy link
Collaborator

Builds ready [9841118]
UI Startup Metrics (1190 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1190109815016212241293
load101487912096010481120
domContentLoaded100686811956010391111
domInteractive18137681739
firstPaint719140120538910291115
backgroundConnect84314921
firstReactRender2316158152336
getState1567592029
initialActions001001
loadScripts80266497759835905
setupStore95385920
WebpackHomeuiStartup22431798293022323402667
load17001348223119618071993
domContentLoaded16931344219919518011979
domInteractive1912138211462
firstPaint1586443072188286
backgroundConnect2610285282650
firstReactRender24192427117378408
getState195327441731
initialActions318135
loadScripts16901342218819317991976
setupStore197220222130
FirefoxBrowserifyHomeuiStartup13681135225616114321695
load11981007208812812511355
domContentLoaded11971007208712812501355
domInteractive1223547370124327
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413146192460
firstReactRender24214842429
getState13526531927
initialActions001001
loadScripts1178995206812612251342
setupStore1048315762
WebpackHomeuiStartup16781425282122717682203
load14371228193316915321832
domContentLoaded14361228193317015321832
domInteractive105565186996288
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2816482462547
firstReactRender43336044651
getState185257351341
initialActions101111
loadScripts14161207190816915141807
setupStore13524931921
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2243 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 242 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2668 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1976 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1695 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 327 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 62 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1679 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1417 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2203 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1832 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1832 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1807 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 328ms | Sum of p95 exceeds: 1405ms
Sum of all benchmark exceeds: 1733ms

@salimtb salimtb force-pushed the fix/fix-aggregated-balance branch from fce492f to 93d127b Compare June 29, 2025 20:49
@metamaskbot
Copy link
Collaborator

Builds ready [93d127b]
UI Startup Metrics (1221 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1221106916837612651328
load104092715527610751136
domContentLoaded103392215447510671126
domInteractive19146391746
firstPaint61083155443310521131
backgroundConnect74223813
firstReactRender23165572343
getState1563272030
initialActions001001
loadScripts828718133374859926
setupStore85263915
WebpackHomeuiStartup21881776271218922692595
load16701315203516017501957
domContentLoaded16641311202415917441946
domInteractive171290131450
firstPaint1636671180183298
backgroundConnect2310279272243
firstReactRender22689404110353396
getState154316311335
initialActions215133
loadScripts16611310201315817431935
setupStore177293281633
FirefoxBrowserifyHomeuiStartup14101219196713614681682
load1228104615139912901413
domContentLoaded1228104615139912901412
domInteractive1273651380130313
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413113152457
firstReactRender26215462732
getState17554957929
initialActions001001
loadScripts1209102814899912761385
setupStore1146614752
WebpackHomeuiStartup16471407224319317752056
load14151204181415415291691
domContentLoaded14141203181415415291690
domInteractive104623926598298
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21153752431
firstReactRender43355944651
getState145193201238
initialActions102111
loadScripts13961187179415415101675
setupStore105668828
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 47 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 2596 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1411 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 128 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1682 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1648 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1396 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2056 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1690 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1675 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 185ms | Sum of p95 exceeds: 720ms
Sum of all benchmark exceeds: 905ms

@metamaskbot
Copy link
Collaborator

Builds ready [9eb4a15]
UI Startup Metrics (1207 ± 83 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207105814988312581359
load103291913017810761197
domContentLoaded102591112917810691192
domInteractive18134951733
firstPaint739130123340010521138
backgroundConnect94356826
firstReactRender23185052434
getState1563172027
initialActions001001
loadScripts819707107778866984
setupStore95244819
WebpackHomeuiStartup21541631270821022492545
load16571220204518817711997
domContentLoaded16511217204118817631992
domInteractive171274131451
firstPaint1686974892171332
backgroundConnect2812320472259
firstReactRender20187439105323400
getState144311311230
initialActions512952934
loadScripts16481215203118717611983
setupStore177288281523
FirefoxBrowserifyHomeuiStartup13791166184113514121670
load1200103315139412371396
domContentLoaded1200103315139412361396
domInteractive1133535261110286
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413135162353
firstReactRender25214442733
getState19440848979
initialActions001001
loadScripts1181101914879412231378
setupStore9417617717
WebpackHomeuiStartup15991351220719916862062
load13821167188316414801756
domContentLoaded13821166188316414801756
domInteractive106323667393314
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415239232244
firstReactRender41315344448
getState1153861223
initialActions102111
loadScripts13611150184616014571738
setupStore11526926827
Benchmark value 1197 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 984 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2545 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1983 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1670 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 286 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 79 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1382 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2062 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1756 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1756 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 314 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1738 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 28ms | Sum of p95 exceeds: 948ms
Sum of all benchmark exceeds: 976ms

@gambinish gambinish merged commit 889bfa4 into feat/network-manager-UI-2 Jun 30, 2025
139 checks passed
@gambinish gambinish deleted the fix/fix-aggregated-balance branch June 30, 2025 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants