-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat: Show < 0.01 when gas cost is really small #33966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+51
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (3 files, +22 -5)
|
Builds ready [37f5da4]
UI Startup Metrics (1223 ± 84 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 832 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1393 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2212 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2588 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2006 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2004 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1433 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1249 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1249 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 125 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1736 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 332 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 97 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 2048 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 294 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1684 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 102ms | Sum of p95 exceeds: 973ms Sum of all benchmark exceeds: 1075ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [8770c4e]
UI Startup Metrics (1174 ± 60 ms)
Benchmark value 1716 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1709 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 250 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1706 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2726 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2050 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2039 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2028 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 263 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 79 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 65 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1630 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1393 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1393 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1371 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2057 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1715 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1714 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1687 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 187ms | Sum of p95 exceeds: 983ms Sum of all benchmark exceeds: 1170ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Jul 2, 2025
OGPoyraz
approved these changes
Jul 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.23.0
Issue or pull request that will be included in release 12.23.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes the following flows:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5256
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist