fix: bridge token address gets copied when Max button is clicked #33965

micaelae · 2025-06-27T16:20:01Z

Description

Fixing a bug where the src token address gets copied to clipboard when the Max button is clicked. Also setting a fixed height for the balance row so it doesn't flicker when user changes the token or loads the page

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-2523

Manual testing steps

Go to bridge and select ERC20 src token
Select ERC20 dest token
Click Max
Verify that address did not get copied to clipboard
Verify that max amount is set
Set amount greater than max
Verify that balance amount turns red
Click dest token address
Verify that block explorer link is copied

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-06-27T16:22:12Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (3 files, +71 -111)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 __snapshots__/
      - 📄 index.test.tsx.snap +5 -19
    - 📁 prepare/
      - 📁 __snapshots__/
        
        📄 prepare-bridge-page.test.tsx.snap +10 -38
        
        📄 bridge-input-group.tsx +56 -54

metamaskbot · 2025-06-27T16:44:47Z

Builds ready [1d98033]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1172 ± 52 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1172	1076	1299	52	1214	1266
			load	1001	916	1098	44	1033	1066
			domContentLoaded	994	907	1090	43	1025	1054
			domInteractive	18	13	49	7	17	40
			firstPaint	643	133	1069	393	1019	1049
			backgroundConnect	8	4	33	5	8	23
			firstReactRender	21	17	43	4	21	26
			getState	14	6	33	7	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	790	707	886	42	819	851
			setupStore	8	5	21	3	8	17
	Webpack	Home	uiStartup	2144	1594	2669	223	2262	2546
			load	1637	1192	2020	192	1755	1970
			domContentLoaded	1631	1188	2015	191	1752	1960
			domInteractive	17	11	62	13	13	56
			firstPaint	160	66	386	66	176	313
			backgroundConnect	24	10	279	28	22	35
			firstReactRender	229	88	420	118	377	405
			getState	11	4	35	6	12	25
			initialActions	2	1	6	1	3	4
			loadScripts	1626	1187	2005	190	1745	1949
			setupStore	16	6	236	23	16	22
Firefox	Browserify	Home	uiStartup	1475	1212	2277	158	1543	1797
			load	1282	1072	2128	129	1342	1430
			domContentLoaded	1282	1072	2128	129	1341	1430
			domInteractive	134	37	552	88	131	337
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	15	229	25	27	76
			firstReactRender	26	22	36	3	28	32
			getState	15	5	222	30	10	54
			initialActions	0	0	2	0	0	1
			loadScripts	1258	1061	2102	125	1326	1398
			setupStore	15	4	217	30	10	66
	Webpack	Home	uiStartup	1592	1368	2559	212	1681	2089
			load	1370	1188	2000	167	1481	1787
			domContentLoaded	1369	1187	2000	167	1480	1787
			domInteractive	100	32	469	74	91	275
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	285	27	25	41
			firstReactRender	41	32	54	4	44	47
			getState	17	6	216	28	13	33
			initialActions	0	0	2	1	1	1
			loadScripts	1350	1167	1981	166	1464	1765
			setupStore	9	5	42	7	8	28

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2546 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1476 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1282 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1282 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 134 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1258 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1797 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 337 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 76 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 54 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 2089 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1787 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1787 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1765 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 225ms | Sum of p95 exceeds: 1150ms
Sum of all benchmark exceeds: 1375ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0%)
ui: 96 Bytes (0%)
common: 15 Bytes (0%)

metamaskbot · 2025-06-27T17:23:56Z

Builds ready [79f442b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1190 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1190	1079	1414	65	1240	1306
			load	1020	916	1229	62	1056	1135
			domContentLoaded	1013	910	1218	62	1050	1125
			domInteractive	18	14	58	7	17	39
			firstPaint	649	80	1226	411	1031	1132
			backgroundConnect	8	4	24	3	8	13
			firstReactRender	23	16	45	7	25	41
			getState	14	6	69	9	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	808	706	999	62	846	922
			setupStore	8	5	19	3	9	17
	Webpack	Home	uiStartup	2243	1776	2766	204	2340	2666
			load	1706	1281	2190	171	1796	2005
			domContentLoaded	1699	1277	2185	169	1792	1991
			domInteractive	18	12	118	16	14	64
			firstPaint	166	63	680	82	175	335
			backgroundConnect	28	9	350	43	28	46
			firstReactRender	245	90	423	111	364	406
			getState	13	4	60	8	17	29
			initialActions	2	1	7	1	3	4
			loadScripts	1696	1276	2175	168	1790	1979
			setupStore	19	7	259	26	22	35
Firefox	Browserify	Home	uiStartup	1374	1231	1793	117	1419	1636
			load	1196	1062	1440	79	1252	1346
			domContentLoaded	1196	1062	1439	79	1252	1345
			domInteractive	114	36	451	71	114	315
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	146	16	21	37
			firstReactRender	25	21	58	4	25	30
			getState	11	4	97	15	9	33
			initialActions	0	0	1	0	0	1
			loadScripts	1179	1045	1424	78	1237	1331
			setupStore	10	4	206	21	7	26
	Webpack	Home	uiStartup	1604	1385	2592	210	1710	2032
			load	1376	1181	1941	160	1498	1682
			domContentLoaded	1376	1180	1941	160	1498	1681
			domInteractive	100	33	343	66	91	287
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	15	360	35	24	44
			firstReactRender	42	32	56	4	45	49
			getState	17	7	307	30	13	39
			initialActions	1	0	2	1	1	1
			loadScripts	1356	1161	1923	159	1472	1662
			setupStore	11	5	123	15	8	32

Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 2243 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 246 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2667 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1980 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 315 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 2032 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1662 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 76ms | Sum of p95 exceeds: 711ms
Sum of all benchmark exceeds: 787ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0%)
ui: 96 Bytes (0%)
common: 15 Bytes (0%)

metamaskbot · 2025-06-27T18:05:33Z

Builds ready [ad3e6c0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1080	1424	74	1229	1374
			load	1020	918	1236	71	1055	1199
			domContentLoaded	1013	914	1225	71	1047	1192
			domInteractive	18	14	45	6	17	34
			firstPaint	679	100	1209	403	1029	1092
			backgroundConnect	8	4	33	4	8	13
			firstReactRender	22	17	58	6	23	36
			getState	15	6	46	9	20	32
			initialActions	0	0	1	0	0	0
			loadScripts	807	705	1015	70	843	983
			setupStore	9	5	26	4	9	17
	Webpack	Home	uiStartup	2273	1812	2848	239	2396	2755
			load	1742	1363	2134	200	1863	2040
			domContentLoaded	1735	1358	2112	198	1858	2028
			domInteractive	19	12	72	14	15	60
			firstPaint	168	67	403	78	177	347
			backgroundConnect	26	10	290	29	25	53
			firstReactRender	223	93	413	104	334	405
			getState	14	5	79	11	14	39
			initialActions	3	1	5	1	3	4
			loadScripts	1732	1356	2100	196	1857	2017
			setupStore	17	7	58	9	20	39
Firefox	Browserify	Home	uiStartup	1400	1241	1865	119	1444	1665
			load	1224	1081	1555	83	1285	1378
			domContentLoaded	1224	1080	1555	83	1285	1378
			domInteractive	119	35	573	76	122	251
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	86	12	23	48
			firstReactRender	25	22	34	2	25	30
			getState	11	5	89	12	9	27
			initialActions	0	0	1	0	0	1
			loadScripts	1204	1063	1540	84	1265	1361
			setupStore	11	4	238	26	6	24
	Webpack	Home	uiStartup	1653	1367	2293	203	1761	2128
			load	1432	1175	1969	169	1541	1719
			domContentLoaded	1431	1175	1969	169	1540	1718
			domInteractive	105	31	387	73	91	314
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	70	9	23	40
			firstReactRender	41	33	54	4	43	47
			getState	15	7	119	15	12	42
			initialActions	1	0	2	1	1	1
			loadScripts	1413	1160	1946	168	1524	1701
			setupStore	11	5	182	18	9	31

Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 983 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2273 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1742 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1735 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1732 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2755 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2041 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2029 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 347 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2017 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1665 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1653 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1432 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1432 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1413 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2128 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1719 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 314 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 42 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1701 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 394ms | Sum of p95 exceeds: 1125ms
Sum of all benchmark exceeds: 1519ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0%)
ui: 70 Bytes (0%)
common: 15 Bytes (0%)

fix: prevent copying token address on Max button click

1d98033

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jun 27, 2025

test: update bridge page snapshots

79f442b

micaelae added 2 commits June 27, 2025 10:39

chore: remove unnecessary Row and set fixed height for balance row

dc68e72

test: update snapshots

ad3e6c0

micaelae marked this pull request as ready for review June 27, 2025 18:16

micaelae requested a review from a team as a code owner June 27, 2025 18:16

ghgoodreau approved these changes Jun 27, 2025

View reviewed changes

micaelae enabled auto-merge June 27, 2025 18:39

SteP-n-s approved these changes Jun 30, 2025

View reviewed changes

micaelae added this pull request to the merge queue Jun 30, 2025

Merged via the queue into main with commit 2ce425c Jun 30, 2025
149 checks passed

micaelae deleted the swaps2523-bridge-max-button-copies-address branch June 30, 2025 16:28

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

metamaskbot added the release-12.23.0 Issue or pull request that will be included in release 12.23.0 label Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: bridge token address gets copied when Max button is clicked #33965

fix: bridge token address gets copied when Max button is clicked #33965

micaelae commented Jun 27, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 27, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

fix: bridge token address gets copied when Max button is clicked #33965

fix: bridge token address gets copied when Max button is clicked #33965

Conversation

micaelae commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

micaelae commented Jun 27, 2025 •

edited

Loading

metamaskbot commented Jun 27, 2025 •

edited

Loading