feat: configure enforced simulations slippage #33924

matthewwalsh0 · 2025-06-26T11:13:16Z

Description

Configure slippage applied to delegation caveats when enforced simulations is enabled.

Specifically:

Add enforcedSimulationsSlippage and enforcedSimulationsSlippageForTransactions to AppStateController.
Refactor SimulationSettingsModal component to better modularise components and handlers.
Apply saved slippage in enforceSimulations util.

Related issues

Fixes: #5174

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-06-26T11:28:50Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (5 files, +182 -49)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 modals/
        
        📁 simulation-settings-modal/
        
        📄 simulation-settings-modal.test.tsx +34 -6
        
        📄 simulation-settings-modal.tsx +128 -43
    - 📁 selectors/
      - 📄 confirm.test.ts +2 -0
      - 📄 confirm.ts +16 -0
    - 📁 types/
      - 📄 confirm.ts +2 -0

metamaskbot · 2025-06-26T11:50:24Z

Builds ready [071fd42]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1199 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1199	1071	1351	61	1235	1299
			load	1030	922	1189	57	1067	1112
			domContentLoaded	1022	917	1183	58	1060	1102
			domInteractive	18	14	50	7	17	41
			firstPaint	708	86	1197	407	1046	1109
			backgroundConnect	9	4	36	6	8	28
			firstReactRender	22	18	53	6	22	37
			getState	13	6	33	7	21	25
			initialActions	0	0	1	0	0	1
			loadScripts	814	707	978	56	852	890
			setupStore	8	5	25	3	8	17
	Webpack	Home	uiStartup	2282	1817	2854	223	2386	2735
			load	1740	1361	2212	193	1841	2068
			domContentLoaded	1734	1357	2207	191	1837	2056
			domInteractive	19	12	105	17	14	60
			firstPaint	171	63	441	68	191	312
			backgroundConnect	28	11	336	38	26	46
			firstReactRender	233	95	415	113	368	406
			getState	12	5	28	5	15	25
			initialActions	3	1	7	1	3	5
			loadScripts	1731	1355	2197	190	1835	2045
			setupStore	24	7	270	43	20	43
Firefox	Browserify	Home	uiStartup	1359	1181	1686	104	1411	1597
			load	1194	1051	1411	78	1251	1348
			domContentLoaded	1194	1051	1410	78	1251	1348
			domInteractive	116	36	529	74	124	195
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	123	12	21	35
			firstReactRender	24	21	33	2	24	29
			getState	11	5	82	13	9	35
			initialActions	0	0	1	0	0	1
			loadScripts	1175	1039	1354	76	1234	1325
			setupStore	7	4	30	4	8	15
	Webpack	Home	uiStartup	1585	1413	2217	179	1682	2047
			load	1366	1213	1887	148	1479	1697
			domContentLoaded	1366	1213	1886	148	1479	1696
			domInteractive	91	33	323	58	85	308
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	46	6	23	37
			firstReactRender	42	32	55	4	44	49
			getState	14	7	90	10	12	32
			initialActions	0	0	1	0	1	1
			loadScripts	1347	1192	1865	148	1459	1675
			setupStore	9	5	40	6	8	26

Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2282 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1741 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1735 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1731 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2735 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2068 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2057 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2045 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2047 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1697 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1696 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 308 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1675 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 195ms | Sum of p95 exceeds: 888ms
Sum of all benchmark exceeds: 1083ms

metamaskbot · 2025-06-26T12:48:17Z

Builds ready [260f855]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1175 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1175	1066	1358	65	1219	1286
			load	1013	889	1175	63	1048	1128
			domContentLoaded	1006	884	1168	63	1038	1122
			domInteractive	17	13	46	7	16	40
			firstPaint	756	69	1163	377	1032	1108
			backgroundConnect	7	4	26	4	8	11
			firstReactRender	21	16	41	4	22	29
			getState	14	6	38	7	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	803	686	961	62	833	920
			setupStore	8	5	26	4	8	17
	Webpack	Home	uiStartup	2203	1724	2833	229	2324	2652
			load	1678	1308	2184	196	1772	2035
			domContentLoaded	1672	1304	2175	195	1768	2022
			domInteractive	18	12	78	15	14	60
			firstPaint	168	65	655	74	192	289
			backgroundConnect	20	10	40	7	23	36
			firstReactRender	249	89	428	122	382	410
			getState	14	4	266	26	14	23
			initialActions	2	1	6	1	3	4
			loadScripts	1669	1302	2165	193	1766	2011
			setupStore	21	7	312	42	18	26
Firefox	Browserify	Home	uiStartup	1343	1172	1731	117	1371	1661
			load	1178	1037	1450	86	1226	1347
			domContentLoaded	1178	1037	1450	86	1226	1347
			domInteractive	113	36	331	57	119	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	142	20	21	57
			firstReactRender	24	21	39	3	24	28
			getState	10	5	98	10	9	28
			initialActions	0	0	1	0	0	1
			loadScripts	1158	1027	1412	83	1206	1326
			setupStore	8	4	77	8	6	25
	Webpack	Home	uiStartup	1653	1375	2107	171	1772	1986
			load	1435	1175	1728	143	1557	1646
			domContentLoaded	1435	1175	1728	143	1557	1645
			domInteractive	96	33	300	50	96	287
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	71	8	22	40
			firstReactRender	42	32	59	4	45	50
			getState	14	7	117	13	12	34
			initialActions	0	0	2	1	1	1
			loadScripts	1416	1161	1699	142	1540	1627
			setupStore	10	5	71	10	8	31

Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 249 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2652 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2035 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2022 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 410 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2011 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 295 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1654 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1436 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1436 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1417 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1986 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 241ms | Sum of p95 exceeds: 596ms
Sum of all benchmark exceeds: 837ms

metamaskbot · 2025-06-28T21:25:45Z

Builds ready [7fd8c5e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1175 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1175	1081	1409	59	1212	1293
			load	1009	923	1206	54	1038	1110
			domContentLoaded	1003	917	1197	54	1030	1103
			domInteractive	17	13	46	6	16	40
			firstPaint	724	80	1234	388	1030	1077
			backgroundConnect	7	4	30	3	7	9
			firstReactRender	20	16	34	2	21	23
			getState	15	6	34	7	20	28
			initialActions	0	0	1	0	0	0
			loadScripts	798	714	994	52	825	893
			setupStore	8	6	20	3	8	17
	Webpack	Home	uiStartup	2282	1741	2768	212	2385	2690
			load	1748	1267	2057	171	1831	2029
			domContentLoaded	1741	1262	2046	170	1826	2012
			domInteractive	20	12	158	23	14	71
			firstPaint	166	67	514	75	204	274
			backgroundConnect	22	10	51	8	25	43
			firstReactRender	236	91	413	107	358	399
			getState	13	5	50	8	15	30
			initialActions	2	1	5	1	3	4
			loadScripts	1738	1261	2035	169	1825	2003
			setupStore	26	7	333	50	21	51
Firefox	Browserify	Home	uiStartup	1334	1193	1633	97	1368	1568
			load	1172	1037	1400	74	1218	1309
			domContentLoaded	1171	1037	1400	74	1218	1309
			domInteractive	116	34	457	71	114	310
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	80	9	21	37
			firstReactRender	24	20	52	3	24	28
			getState	10	4	74	10	9	32
			initialActions	0	0	1	0	0	1
			loadScripts	1153	1024	1373	74	1200	1293
			setupStore	8	4	76	10	8	23
	Webpack	Home	uiStartup	1582	1369	2115	157	1669	1926
			load	1370	1188	1689	128	1469	1621
			domContentLoaded	1370	1187	1689	128	1469	1620
			domInteractive	95	29	484	66	91	279
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	51	6	21	40
			firstReactRender	41	32	70	5	43	47
			getState	13	6	108	14	11	34
			initialActions	1	0	2	1	1	1
			loadScripts	1352	1171	1671	128	1450	1603
			setupStore	10	5	107	15	8	30

Benchmark value 2283 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1748 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1742 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 236 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1739 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2691 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2012 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 399 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2004 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 310 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 279 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 217ms | Sum of p95 exceeds: 571ms
Sum of all benchmark exceeds: 788ms

metamaskbot · 2025-06-28T21:54:19Z

Builds ready [d1b2dd1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1069	1332	59	1230	1291
			load	1022	917	1140	56	1062	1110
			domContentLoaded	1016	913	1131	56	1057	1102
			domInteractive	18	14	54	8	16	42
			firstPaint	696	79	1138	408	1042	1105
			backgroundConnect	7	4	30	4	7	12
			firstReactRender	23	17	56	6	22	38
			getState	14	6	36	8	21	29
			initialActions	0	0	1	0	0	1
			loadScripts	811	711	927	56	853	894
			setupStore	8	5	21	3	8	16
	Webpack	Home	uiStartup	2169	1745	2678	213	2282	2616
			load	1649	1225	2043	191	1765	1988
			domContentLoaded	1643	1217	2033	190	1757	1972
			domInteractive	17	12	75	14	13	55
			firstPaint	169	64	1976	191	175	289
			backgroundConnect	27	10	411	47	24	41
			firstReactRender	235	90	419	119	380	402
			getState	11	4	29	5	12	25
			initialActions	2	1	6	1	3	4
			loadScripts	1638	1215	2023	188	1752	1966
			setupStore	22	7	310	43	18	26
Firefox	Browserify	Home	uiStartup	1337	1182	1630	96	1395	1514
			load	1178	1052	1375	74	1226	1329
			domContentLoaded	1178	1051	1375	74	1226	1329
			domInteractive	108	35	406	51	119	182
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	77	10	21	34
			firstReactRender	24	20	81	7	23	28
			getState	10	4	73	9	9	27
			initialActions	0	0	1	0	0	1
			loadScripts	1161	1035	1357	72	1208	1302
			setupStore	7	4	75	8	7	17
	Webpack	Home	uiStartup	1599	1400	2211	181	1677	2045
			load	1381	1206	1886	151	1470	1695
			domContentLoaded	1380	1206	1886	151	1470	1694
			domInteractive	101	32	518	77	89	292
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	85	10	24	42
			firstReactRender	42	32	65	4	44	48
			getState	15	6	100	13	13	38
			initialActions	0	0	2	1	1	1
			loadScripts	1361	1189	1865	150	1457	1677
			setupStore	10	5	92	10	8	21

Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 2616 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1381 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1361 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2045 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1695 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1694 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1677 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 566ms
Sum of all benchmark exceeds: 574ms

metamaskbot · 2025-06-29T00:50:31Z

Builds ready [454fa06]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1081	1351	58	1244	1293
			load	1028	921	1178	58	1071	1120
			domContentLoaded	1022	911	1173	58	1066	1111
			domInteractive	17	14	46	5	17	26
			firstPaint	684	78	1174	420	1051	1114
			backgroundConnect	7	4	28	4	7	13
			firstReactRender	22	17	45	6	23	42
			getState	14	7	30	7	20	28
			initialActions	0	0	1	0	0	1
			loadScripts	816	708	962	57	861	904
			setupStore	8	5	21	3	8	17
	Webpack	Home	uiStartup	2127	1632	2626	225	2254	2543
			load	1625	1219	2171	187	1714	1930
			domContentLoaded	1619	1211	2166	186	1708	1915
			domInteractive	16	12	68	11	13	47
			firstPaint	163	65	631	77	174	289
			backgroundConnect	19	11	41	6	21	33
			firstReactRender	227	87	413	118	379	392
			getState	11	4	41	6	12	23
			initialActions	2	1	4	1	2	3
			loadScripts	1616	1209	2156	184	1706	1904
			setupStore	19	7	311	42	15	25
Firefox	Browserify	Home	uiStartup	1396	1234	1817	115	1425	1664
			load	1228	1084	1463	87	1280	1417
			domContentLoaded	1227	1084	1463	87	1280	1417
			domInteractive	112	36	385	58	122	215
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	129	18	22	48
			firstReactRender	25	21	53	5	25	30
			getState	11	4	85	12	9	39
			initialActions	0	0	1	0	0	1
			loadScripts	1206	1071	1444	82	1261	1386
			setupStore	9	4	72	10	10	24
	Webpack	Home	uiStartup	1615	1405	2293	171	1705	2032
			load	1395	1210	2043	143	1494	1683
			domContentLoaded	1395	1210	2043	143	1493	1683
			domInteractive	102	32	474	75	91	299
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	52	6	22	30
			firstReactRender	43	35	68	4	45	48
			getState	15	7	108	15	13	35
			initialActions	0	0	1	0	1	1
			loadScripts	1376	1196	2017	143	1476	1656
			setupStore	10	5	42	7	9	33

Benchmark value 2543 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 392 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1664 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 215 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1396 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1376 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2032 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1683 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1683 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 299 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1656 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 59ms | Sum of p95 exceeds: 470ms
Sum of all benchmark exceeds: 529ms

Accept transactionMeta in util.

metamaskbot · 2025-07-10T20:49:14Z

Builds ready [3099d08]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1278 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1278	1133	1458	66	1321	1403
			load	1091	958	1235	60	1135	1187
			domContentLoaded	1084	952	1228	60	1129	1181
			domInteractive	19	14	61	8	18	40
			firstPaint	649	97	1194	438	1095	1153
			backgroundConnect	8	4	42	5	8	14
			firstReactRender	25	17	51	7	25	41
			getState	16	6	36	8	23	30
			initialActions	5	0	28	6	8	18
			loadScripts	827	694	971	59	869	921
			setupStore	9	5	25	4	9	19
	Webpack	Home	uiStartup	2272	1843	2784	192	2359	2727
			load	1731	1346	2074	172	1844	2036
			domContentLoaded	1724	1340	2059	171	1840	2026
			domInteractive	18	12	80	13	15	55
			firstPaint	163	66	478	80	205	343
			backgroundConnect	28	10	358	35	27	47
			firstReactRender	243	90	520	118	375	403
			getState	19	5	320	33	20	46
			initialActions	10	2	168	17	10	19
			loadScripts	1721	1337	2057	170	1839	2012
			setupStore	17	7	57	9	21	38
Firefox	Browserify	Home	uiStartup	1361	1167	1869	137	1419	1661
			load	1191	1034	1590	95	1230	1366
			domContentLoaded	1190	1034	1589	95	1230	1366
			domInteractive	108	34	464	75	102	313
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	121	12	20	34
			firstReactRender	25	22	41	4	27	34
			getState	11	4	81	14	9	57
			initialActions	4	0	146	16	2	11
			loadScripts	1173	1021	1545	93	1211	1345
			setupStore	12	3	79	17	6	67
	Webpack	Home	uiStartup	1674	1391	2351	195	1765	2166
			load	1420	1178	1910	155	1526	1692
			domContentLoaded	1420	1177	1909	155	1525	1691
			domInteractive	101	41	352	63	94	306
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	85	11	24	43
			firstReactRender	59	45	77	6	63	70
			getState	19	5	344	41	14	36
			initialActions	4	0	89	9	3	13
			loadScripts	1401	1163	1887	152	1503	1673
			setupStore	11	5	80	11	9	29

Benchmark value 1278 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1085 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1404 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2272 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1731 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1725 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 244 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1721 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2728 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2036 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2026 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 343 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2013 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 57 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 67 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1674 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1421 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1401 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2166 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1673 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 474ms | Sum of p95 exceeds: 1180.8ms
Sum of all benchmark exceeds: 1654.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.8 KiB (0.05%)
ui: 842 Bytes (0.01%)
common: 33.72 KiB (0.4%)

Add settings hook.

metamaskbot · 2025-07-10T22:25:30Z

Builds ready [ae29a8a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1096	1516	64	1245	1321
			load	1047	955	1289	53	1081	1129
			domContentLoaded	1041	951	1283	52	1076	1124
			domInteractive	18	14	44	7	17	38
			firstPaint	640	85	1290	429	1050	1125
			backgroundConnect	7	3	13	2	8	10
			firstReactRender	24	15	56	8	26	45
			getState	16	6	78	10	21	31
			initialActions	7	0	87	14	8	25
			loadScripts	793	702	1029	52	829	878
			setupStore	9	5	23	4	9	19
	Webpack	Home	uiStartup	2267	1838	2857	213	2363	2729
			load	1718	1348	2089	183	1806	2043
			domContentLoaded	1712	1344	2079	182	1802	2024
			domInteractive	19	13	80	14	15	61
			firstPaint	159	65	428	64	174	303
			backgroundConnect	27	10	331	32	27	44
			firstReactRender	242	93	421	114	371	400
			getState	15	5	48	9	19	36
			initialActions	11	3	168	17	10	30
			loadScripts	1708	1342	2065	180	1800	2019
			setupStore	20	7	193	24	22	35
Firefox	Browserify	Home	uiStartup	1362	1166	1815	126	1423	1595
			load	1184	1033	1435	89	1235	1378
			domContentLoaded	1184	1033	1434	89	1234	1378
			domInteractive	99	38	332	46	105	171
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	128	19	21	52
			firstReactRender	24	21	55	4	25	29
			getState	10	4	77	9	9	27
			initialActions	6	0	175	21	2	20
			loadScripts	1166	1016	1413	86	1216	1350
			setupStore	14	4	197	31	7	69
	Webpack	Home	uiStartup	1682	1393	3680	267	1755	2076
			load	1420	1190	1890	152	1511	1728
			domContentLoaded	1420	1189	1890	152	1511	1728
			domInteractive	105	34	553	85	93	326
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	250	26	23	36
			firstReactRender	58	44	73	5	62	67
			getState	31	5	1562	156	12	34
			initialActions	8	1	242	27	4	23
			loadScripts	1398	1173	1871	149	1487	1672
			setupStore	10	5	53	7	9	24

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 8 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 25 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2267 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1718 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1712 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 242 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1708 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2729 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2043 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2024 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2019 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 69 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1682 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1420 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 32 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1398 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2076 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1728 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1728 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 326 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1672 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 366ms | Sum of p95 exceeds: 1030.8ms
Sum of all benchmark exceeds: 1396.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.8 KiB (0.05%)
ui: -454 Bytes (-0.01%)
common: 33.66 KiB (0.39%)

matthewwalsh0 changed the base branch from main to feat/enforced-simulations-disable June 26, 2025 11:13

matthewwalsh0 force-pushed the feat/enforced-simulations-slippage branch from 91beedf to 071fd42 Compare June 26, 2025 11:26

metamaskbot added the team-confirmations Push issues to confirmations team label Jun 26, 2025

matthewwalsh0 force-pushed the feat/enforced-simulations-slippage branch from f8a4e92 to 7fd8c5e Compare June 28, 2025 21:02

matthewwalsh0 force-pushed the feat/enforced-simulations-disable branch 2 times, most recently from 01d33ef to f23cc17 Compare July 4, 2025 19:44

Base automatically changed from feat/enforced-simulations-disable to main July 9, 2025 18:11

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025

matthewwalsh0 added 9 commits July 10, 2025 21:19

Add slippage state and components

4f52fb1

Apply slippage

924d7e8

Create slippage local component

9a6ec46

Add controller unit tests

7929e46

Add util unit tests

e094925

Accept transactionMeta in util.

Split click handler

ee68ad4

Add translations

ae0748c

Add modal unit tests

cf03522

Fix linting and E2E tests

3099d08

matthewwalsh0 force-pushed the feat/enforced-simulations-slippage branch from 454fa06 to 3099d08 Compare July 10, 2025 20:23

matthewwalsh0 added 2 commits July 10, 2025 22:42

Remove pills

fb18c91

Add settings hook.

Remove translation key

ae29a8a

matthewwalsh0 marked this pull request as ready for review July 14, 2025 11:00

matthewwalsh0 requested a review from a team as a code owner July 14, 2025 11:00

vinistevam approved these changes Jul 21, 2025

View reviewed changes

jpuri approved these changes Jul 23, 2025

View reviewed changes

matthewwalsh0 added this pull request to the merge queue Jul 23, 2025

Merged via the queue into main with commit 7fbb717 Jul 23, 2025
149 checks passed

matthewwalsh0 deleted the feat/enforced-simulations-slippage branch July 23, 2025 16:11

github-actions bot locked and limited conversation to collaborators Jul 23, 2025

metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: configure enforced simulations slippage #33924

feat: configure enforced simulations slippage #33924

matthewwalsh0 commented Jun 26, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 26, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 26, 2025

Uh oh!

metamaskbot commented Jun 26, 2025

Uh oh!

metamaskbot commented Jun 28, 2025

Uh oh!

metamaskbot commented Jun 28, 2025

Uh oh!

metamaskbot commented Jun 29, 2025

Uh oh!

metamaskbot commented Jul 10, 2025

Uh oh!

metamaskbot commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

feat: configure enforced simulations slippage #33924

feat: configure enforced simulations slippage #33924

Conversation

matthewwalsh0 commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 26, 2025

Uh oh!

metamaskbot commented Jun 26, 2025

Uh oh!

metamaskbot commented Jun 28, 2025

Uh oh!

metamaskbot commented Jun 28, 2025

Uh oh!

metamaskbot commented Jun 29, 2025

Uh oh!

metamaskbot commented Jul 10, 2025

Uh oh!

metamaskbot commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

matthewwalsh0 commented Jun 26, 2025 •

edited

Loading

metamaskbot commented Jun 26, 2025 •

edited

Loading