feat: add warning message for Ledger connection issues on Firefox cp-12.23.0 #33915
+137
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces new messages and UI alerts to inform users about the lack of support for Ledger on Firefox. It updates the connection logic to display a warning when a user attempts to connect a Ledger device while using Firefox, guiding them to a support link for alternative solutions.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vivek-consensys
added
needs-qa
Builds ready [a1c5f65]
UI Startup Metrics (1189 ± 50 ms)
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2567 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 254 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 2074 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1680 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1661 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 6ms | Sum of p95 exceeds: 557ms Sum of all benchmark exceeds: 563ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This commit adds a CSS class to the link in the Ledger Firefox support message, enhancing its visibility and user experience. The change aims to improve the overall UI by ensuring that users can easily identify and access the support link.
Builds ready [f21df96]
UI Startup Metrics (1186 ± 61 ms)
Benchmark value 2206 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 248 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2623 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 287 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1402 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1382 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2117 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1705 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1705 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 335 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1681 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 123ms | Sum of p95 exceeds: 816ms Sum of all benchmark exceeds: 939ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [2cbb6e1]
UI Startup Metrics (1187 ± 67 ms)
Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 15ms | Sum of p95 exceeds: 343ms Sum of all benchmark exceeds: 358ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vivek-consensys
added
QA Passed
and removed
needs-qa
Builds ready [090ec34]
UI Startup Metrics (1181 ± 71 ms)
Benchmark value 239 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2626 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 290 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1649 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1412 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2069 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1706 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1706 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 310 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1681 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 209ms | Sum of p95 exceeds: 745ms Sum of all benchmark exceeds: 954ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [be091d3]
UI Startup Metrics (1193 ± 76 ms)
Benchmark value 2257 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 250 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2685 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2012 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 352 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2003 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1425 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1240 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 422 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1667 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1408 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2029 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1690 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 345ms | Sum of p95 exceeds: 1039ms Sum of all benchmark exceeds: 1384ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_cfb215df-27e7-4b26-833b-e6a2e1c0432a). |
Builds ready [2d055b7]
UI Startup Metrics (1183 ± 66 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2235 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2693 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1991 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1413 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 279 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 1981 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 76ms | Sum of p95 exceeds: 580ms Sum of all benchmark exceeds: 656ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…hecks for "Firefox Not Supported" message and refactored account selection logic for improved clarity and maintainability.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [ba3d02d]
UI Startup Metrics (1201 ± 65 ms)
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2286 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1720 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1713 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 236 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1710 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2817 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2107 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2086 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2075 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1485 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1280 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1280 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1259 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 22 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1837 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 318 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 41 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 194 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1700 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1467 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1467 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1446 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2102 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1754 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1754 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 43 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1731 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 713ms | Sum of p95 exceeds: 1772ms Sum of all benchmark exceeds: 2485ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [38b37b7]
UI Startup Metrics (1168 ± 67 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2700 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2121 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2111 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 25 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 71 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2107 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 3233 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2541 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2517 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 83 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 386 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 308 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 373 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 2504 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 247 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1479 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1281 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1281 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1258 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1770 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 306 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 80 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 51 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 86 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1659 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1433 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1410 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2056 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1700 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1700 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 309 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 47 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1681 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2206ms | Sum of p95 exceeds: 3645ms Sum of all benchmark exceeds: 5851ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [44eb354]
UI Startup Metrics (1230 ± 67 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 30 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2206 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2684 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2008 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 77 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1997 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1409 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 129 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1726 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 353 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 63 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1619 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1396 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1396 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1371 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2191 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1783 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1783 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 324 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1746 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 45 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 110ms | Sum of p95 exceeds: 1419ms Sum of all benchmark exceeds: 1529ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vivek-consensys
changed the title
vivek-consensys
added
the
release-12.23.0
ccharly
reviewed
Jul 10, 2025
test/e2e/page-objects/pages/hardware-wallet/connect-hardware-wallet-page.ts
Outdated
Show resolved
Hide resolved
test/e2e/page-objects/pages/hardware-wallet/connect-hardware-wallet-page.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Charly Chevalier <[email protected]>
Builds ready [6b36b23]
UI Startup Metrics (1235 ± 69 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1373 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 23 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2244 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 245 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2705 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2016 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 347 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 25 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2004 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1412 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1770 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 327 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 34 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 62 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1663 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1407 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1407 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1383 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2069 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1752 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1751 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 291 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1677 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 36 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 267ms | Sum of p95 exceeds: 1302.8ms Sum of all benchmark exceeds: 1569.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
…d logic. Changed test assertions to reflect new error messages and refactored browser detection for improved clarity.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ccharly
reviewed
Jul 10, 2025
…ant for platform identification. This improves clarity and maintains consistency in the codebase.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ccharly
approved these changes
Jul 10, 2025
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Builds ready [5f52aa0]
UI Startup Metrics (1241 ± 71 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2305 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1729 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1722 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 272 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1718 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2760 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2053 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2042 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2029 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 295 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 73 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 56 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 51 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1710 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1444 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1444 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1423 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2203 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 343 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 67 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1742 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 578ms | Sum of p95 exceeds: 1571.8ms Sum of all benchmark exceeds: 2149.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Akaryatrh
approved these changes
Jul 10, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-13.0.0
metamaskbot
removed
the
release-13.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new messages and UI alerts to inform users about the lack of support for Ledger on Firefox. It updates the connection logic to display a warning when a user attempts to connect a Ledger device while using Firefox, guiding them to a support link for alternative solutions.
Description
Related issues
Fixes: #28716
Manual testing steps
Start the MM extensions by running
yarn start:mv2and then install MM extensions to firefox developer edition.
Add account or hardware walletledgerFirefox Not Supportedwarning error.continuebutton should be disabled.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist