Reformat root version to include the release no. #22
Conversation
|
|
mcmire
force-pushed
the
simplify-monorepo-workflow-tests
branch
4 times, most recently
from
3db4897 to
c30ce5c
Compare
This commit changes how the root version is bumped per release so that instead of looking like `<yyyy>.<mm>.<dd>`, it looks like `<yyyy><mm><dd>.<release-number>.0`. That is, the root version consists of the date that the release was created + a release number, which is incremented every time a new release is issued.
mcmire
force-pushed
the
include-build-number-in-version
branch
from
c703a77 to
d422085
Compare
| }); | ||
| }); | ||
| }); | ||
|
|
||
| it('collects information about a polyrepo project', async () => { |
There was a problem hiding this comment.
I decided to drop the polyrepo test from this because readProject hasn't technically supported polyrepo projects and that is more true with this PR than before. I think this is something we can fix in a later PR.
|
This is ready for review. |
|
I wasn't able to get to this today. I may have some time this weekend to make these changes but can't promise anything. Sorry :( |
| import { readCommandLineArguments } from './command-line-arguments'; | ||
| import { readProject, Project } from './project'; | ||
|
|
||
| interface InitialParameters { | ||
| project: Project; | ||
| tempDirectoryPath: string; | ||
| reset: boolean; | ||
| today: Date; |
There was a problem hiding this comment.
There's no need to read the date from TODAY nor pass this down to anywhere, as a date isn't used anymore to calculate the version string. So it gets removed from everywhere.
|
This is now updated as per discussion around the release version. |
Co-authored-by: Mark Stacey <[email protected]>
This commit changes how the root version is bumped per release so that
instead of looking like
<yyyy>.<mm>.<dd>, it looks like<yyyy><mm><dd>.<release-number>.0. That is, the root versionconsists of the date that the release was created + a release number,
which is incremented every time a new release is issued.
Fixes #16.