Skip to content

Commit 0882483

Browse files
committed
Remove noisy TODOs
1 parent e8e44ec commit 0882483

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

packages/composable-controller/src/ComposableController.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import type { Patch } from 'immer';
1010

1111
export const controllerName = 'ComposableController';
1212

13-
// TODO: Remove this type once `BaseControllerV2` migrations are completed for all controllers.
1413
/**
1514
* A type encompassing all controller instances that extend from `BaseControllerV1`.
1615
*/
@@ -34,7 +33,6 @@ export type BaseControllerV2Instance = {
3433
state: StateConstraint;
3534
};
3635

37-
// TODO: Remove `BaseControllerV1Instance` member once `BaseControllerV2` migrations are completed for all controllers.
3836
/**
3937
* A type encompassing all controller instances that extend from `BaseControllerV1` or `BaseController`.
4038
*
@@ -48,7 +46,6 @@ export type ControllerInstance =
4846
* Determines if the given controller is an instance of BaseControllerV1
4947
* @param controller - Controller instance to check
5048
* @returns True if the controller is an instance of BaseControllerV1
51-
* TODO: Deprecate once `BaseControllerV2` migrations are completed for all controllers.
5249
*/
5350
export function isBaseControllerV1(
5451
controller: ControllerInstance,
@@ -86,10 +83,10 @@ export function isBaseController(
8683
);
8784
}
8885

86+
// TODO: Replace `any` with `Json` once `BaseControllerV2` migrations are completed for all controllers.
8987
export type ComposableControllerState = {
9088
// `any` is used here to disable the `BaseController` type constraint which expects state properties to extend `Record<string, Json>`.
9189
// `ComposableController` state needs to accommodate `BaseControllerV1` state objects that may have properties wider than `Json`.
92-
// TODO: Replace `any` with `Json` once `BaseControllerV2` migrations are completed for all controllers.
9390
// eslint-disable-next-line @typescript-eslint/no-explicit-any
9491
[name: string]: Record<string, any>;
9592
};
@@ -171,7 +168,6 @@ export class ComposableController extends BaseController<
171168
/**
172169
* Constructor helper that subscribes to child controller state changes.
173170
* @param controller - Controller instance to update
174-
* TODO: Remove `isBaseControllerV1` branch once `BaseControllerV2` migrations are completed for all controllers.
175171
*/
176172
#updateChildController(controller: ControllerInstance): void {
177173
if (!isBaseController(controller) && !isBaseControllerV1(controller)) {

0 commit comments

Comments
 (0)