Remove package-level exports for BaseControllerV{1,2}Instance, ControllerInstance, as these are unsuited for general use

Author: MajorLift

packages/composable-controller/CHANGELOG.md

@@ -10,7 +10,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Add and export functions `isBaseControllerV1` and `isBaseController`, which are type guards for validating controller instances ([#3904](https://github.com/MetaMask/core/pull/3904))
-- Add and export types `BaseControllerV1Instance`, `BaseControllerV2Instance`, `ControllerInstance` which are the narrowest supertypes for all controllers extending from, respectively, `BaseControllerV1`, `BaseController`, and both ([#3904](https://github.com/MetaMask/core/pull/3904))
 
 ### Changed
 

packages/composable-controller/src/ComposableController.ts

@@ -26,6 +26,8 @@ export type BaseControllerV1Instance =
  * because the generic parameters it expects require knowing the exact shape of the controller's state and messenger.
  *
  * Instead, we look for an object with the `BaseController` properties that we use in the ComposableController (name and state).
+ *
+ * Note that this type is not sufficiently type-safe for general use, and is only intended for use within the ComposableController.
  */
 export type BaseControllerV2Instance = {
   name: string;
@@ -35,6 +37,8 @@ export type BaseControllerV2Instance = {
 // TODO: Remove `BaseControllerV1Instance` member once `BaseControllerV2` migrations are completed for all controllers.
 /**
  * A type encompassing all controller instances that extend from `BaseControllerV1` or `BaseController`.
+ *
+ * Note that this type is not sufficiently type-safe for general use, and is only intended for use within the ComposableController.
  */
 export type ControllerInstance =
   | BaseControllerV1Instance

packages/composable-controller/src/index.ts

@@ -1,7 +1,4 @@
 export type {
-  BaseControllerV1Instance,
-  BaseControllerV2Instance,
-  ControllerInstance,
   ComposableControllerState,
   ComposableControllerStateChangeEvent,
   ComposableControllerEvents,