Skip to content

Upgrade & consolidate GitHub workflows #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Apr 24, 2025

Bring the GitHub workflows closer to the module template:

  • Add a main workflow
  • Create a build-lint-test workflow
  • Consolidate the test workflows into build-lint-test
  • Add lint:changelog package script, and add @metamask/auto-changelog to devDependencies
  • Simplify lint step in build-lint-test
  • Sync create-release-pr workflow with module template
  • Ensure all actions are up to date

Copy link

socket-security bot commented Apr 24, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​auto-changelog@​3.4.49610010092100

View full report

Copy link

socket-security bot commented Apr 24, 2025

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Block Medium
[email protected] has Shell access.

Module: child_process

Location: Package overview

Source: package.json

ℹ Read more on: This package | This alert | What is shell access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Low
[email protected] has a New author.

New Author: explodingcabbage

Previous Author: kpdecker

Source: package.json

ℹ Read more on: This package | This alert | What is new author?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Low
[email protected] has a New author.

New Author: stevemao

Previous Author: shinnn

Source: package.json

ℹ Read more on: This package | This alert | What is new author?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@mcmire mcmire marked this pull request as ready for review April 24, 2025 18:16
@mcmire mcmire requested a review from a team as a code owner April 24, 2025 18:16
@mcmire mcmire marked this pull request as draft April 24, 2025 18:17
Bring the GitHub workflows closer to the module template:

- Add a `main` workflow
- Create a `build-lint-test` workflow
- Consolidate the test workflows into `build-lint-test`
- Add `lint:changelog` package script, and add `@metamask/auto-changelog`
  to `devDependencies`
- Simplify lint step in `build-lint-test`
- Sync `create-release-pr` workflow with module template
- Ensure all actions are up to date
@mcmire mcmire force-pushed the update-workflows branch from f9683f6 to 3f9559c Compare April 24, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant